From: Jessica Yu <jeyu@redhat.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Vojtech Pavlik <vojtech@suse.com>,
Miroslav Benes <mbenes@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Jessica Yu <jeyu@redhat.com>
Subject: [PATCH 2/2] ftrace: Adjust priority of ftrace module notifier
Date: Fri, 29 Jan 2016 01:43:47 -0500 [thread overview]
Message-ID: <1454049827-3726-3-git-send-email-jeyu@redhat.com> (raw)
In-Reply-To: <1454049827-3726-1-git-send-email-jeyu@redhat.com>
Adjust the priority of the ftrace module notifier such that it will run
before the livepatch coming module notifier but after the livepatch going
module modifier.
This fixes a notifier ordering issue in which the ftrace module notifier
(and hence ftrace_module_enable()) for COMING modules was being called
after klp_module_notify(), which caused livepatch modules to initialize
incorrectly.
Signed-off-by: Jessica Yu <jeyu@redhat.com>
---
kernel/trace/ftrace.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index eca592f..bdd7bfc 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -5067,7 +5067,12 @@ static int ftrace_module_notify(struct notifier_block *self,
struct notifier_block ftrace_module_nb = {
.notifier_call = ftrace_module_notify,
- .priority = INT_MIN, /* Run after anything that can remove kprobes */
+ /*
+ * Run after anything that can remove kprobes and
+ * after livepatch's going notifier, but run before
+ * livepatch's coming notifier.
+ */
+ .priority = INT_MIN+1,
};
void __init ftrace_init(void)
--
2.4.3
next prev parent reply other threads:[~2016-01-29 6:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 6:43 [PATCH 0/2] Fix ordering of ftrace + livepatch module notifier callbacks Jessica Yu
2016-01-29 6:43 ` [PATCH 1/2] livepatch: Implement separate coming and going module notifiers Jessica Yu
2016-01-29 16:30 ` Miroslav Benes
2016-01-29 17:30 ` Josh Poimboeuf
2016-01-29 17:40 ` Steven Rostedt
2016-01-29 17:58 ` Josh Poimboeuf
2016-01-29 19:25 ` Miroslav Benes
2016-01-29 19:29 ` Steven Rostedt
2016-01-29 19:47 ` Josh Poimboeuf
2016-01-29 20:08 ` Steven Rostedt
2016-01-29 20:15 ` Josh Poimboeuf
2016-02-01 12:27 ` Jiri Kosina
2016-02-01 14:48 ` Josh Poimboeuf
2016-01-29 19:51 ` Jessica Yu
2016-01-29 19:42 ` [PATCH 1/2] " Josh Poimboeuf
2016-01-29 22:58 ` Jessica Yu
2016-01-30 0:02 ` Steven Rostedt
2016-02-01 14:37 ` Josh Poimboeuf
2016-01-29 20:04 ` Jessica Yu
2016-01-29 20:09 ` Steven Rostedt
2016-01-29 20:10 ` Steven Rostedt
2016-01-29 20:20 ` Josh Poimboeuf
2016-01-29 6:43 ` Jessica Yu [this message]
2016-01-29 14:38 ` [PATCH 2/2] ftrace: Adjust priority of ftrace module notifier Steven Rostedt
2016-01-29 15:45 ` Josh Poimboeuf
2016-01-29 15:49 ` Steven Rostedt
2016-01-29 15:50 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454049827-3726-3-git-send-email-jeyu@redhat.com \
--to=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®