From: Arnd Bergmann <arnd@arndb.de>
To: linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/6] ARM: s3c24xx: don't select EEPROM_AT24
Date: Fri, 29 Jan 2016 15:50:33 +0100 [thread overview]
Message-ID: <1454079040-3567945-2-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1454079040-3567945-1-git-send-email-arnd@arndb.de>
EEPROM_AT24 depends on both I2C and SYSFS. We have in the past
added I2C 'select' statements to avoid build problems with the
first, but we still get a warning because of the second:
warning: (MACH_DAVINCI_EVM && MACH_SFFSDR && MACH_DAVINCI_DM6467_EVM && MACH_DAVINCI_DM365_EVM && MACH_DAVINCI_DA830_EVM && MACH_MITYOMAPL138 && MACH_MINI2440) selects EEPROM_AT24 which has unmet direct dependencies (I2C && SYSFS)
This removes the 'select' statements again, and forces users to
enable the driver in their configuration files, as we do for
most other drivers.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/configs/mini2440_defconfig | 1 +
arch/arm/configs/s3c2410_defconfig | 1 +
arch/arm/mach-s3c24xx/Kconfig | 1 -
3 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/configs/mini2440_defconfig b/arch/arm/configs/mini2440_defconfig
index 9c93f5655248..0b02e4f43c6a 100644
--- a/arch/arm/configs/mini2440_defconfig
+++ b/arch/arm/configs/mini2440_defconfig
@@ -158,6 +158,7 @@ CONFIG_I2C=y
CONFIG_I2C_CHARDEV=y
CONFIG_I2C_S3C2410=y
CONFIG_I2C_SIMTEC=y
+CONFIG_EEPROM_AT24=y
CONFIG_SPI=y
CONFIG_SPI_S3C24XX=y
CONFIG_SPI_SPIDEV=y
diff --git a/arch/arm/configs/s3c2410_defconfig b/arch/arm/configs/s3c2410_defconfig
index f3142369f594..b3ade552a2a5 100644
--- a/arch/arm/configs/s3c2410_defconfig
+++ b/arch/arm/configs/s3c2410_defconfig
@@ -290,6 +290,7 @@ CONFIG_HW_RANDOM=y
CONFIG_I2C_CHARDEV=m
CONFIG_I2C_S3C2410=y
CONFIG_I2C_SIMTEC=y
+CONFIG_EEPROM_AT24=y
CONFIG_SPI=y
CONFIG_SPI_GPIO=m
CONFIG_SPI_S3C24XX=m
diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig
index ef68ecb27396..c94ef77405ed 100644
--- a/arch/arm/mach-s3c24xx/Kconfig
+++ b/arch/arm/mach-s3c24xx/Kconfig
@@ -460,7 +460,6 @@ config MACH_AT2440EVB
config MACH_MINI2440
bool "MINI2440 development board"
- select EEPROM_AT24 if I2C
select LEDS_CLASS
select LEDS_TRIGGERS
select LEDS_TRIGGER_BACKLIGHT
--
2.7.0
next parent reply other threads:[~2016-01-29 14:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1454079040-3567945-1-git-send-email-arnd@arndb.de>
2016-01-29 14:50 ` Arnd Bergmann [this message]
2016-02-01 0:40 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 2/6] ARM: s3c24xx: allow selecting S3C2440_XTAL_16934400 for s3c2442 Arnd Bergmann
2016-02-01 0:46 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning Arnd Bergmann
2016-02-01 0:49 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled Arnd Bergmann
2016-02-01 0:59 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 5/6] ARM: s3c64xx: mark regulator init data as unused Arnd Bergmann
2016-02-01 1:18 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 6/6] ARM: exynos: select THERMAL_OF Arnd Bergmann
2016-02-01 1:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454079040-3567945-2-git-send-email-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome