mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>, Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning
Date: Fri, 29 Jan 2016 15:50:35 +0100	[thread overview]
Message-ID: <1454079040-3567945-4-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1454079040-3567945-1-git-send-email-arnd@arndb.de>

gta02_configure_pmu_for_charger is only used when CONFIG_PCF50633_ADC
is set, and otherwise we get a warning about an unused symbol:

arch/arm/mach-s3c24xx/mach-gta02.c:158:1: warning: 'gta02_configure_pmu_for_charger' defined but not used [-Wunused-function]
 gta02_configure_pmu_for_charger(struct pcf50633 *pcf, void *unused, int res)

This adds an #ifdef to shut up the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-s3c24xx/mach-gta02.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-s3c24xx/mach-gta02.c b/arch/arm/mach-s3c24xx/mach-gta02.c
index 6d1e0b9c5b27..27ae6877550f 100644
--- a/arch/arm/mach-s3c24xx/mach-gta02.c
+++ b/arch/arm/mach-s3c24xx/mach-gta02.c
@@ -154,6 +154,7 @@ static struct s3c2410_uartcfg gta02_uartcfgs[] = {
 #define ADC_NOM_CHG_DETECT_1A 6
 #define ADC_NOM_CHG_DETECT_USB 43
 
+#ifdef CONFIG_PCF50633_ADC
 static void
 gta02_configure_pmu_for_charger(struct pcf50633 *pcf, void *unused, int res)
 {
@@ -174,6 +175,7 @@ gta02_configure_pmu_for_charger(struct pcf50633 *pcf, void *unused, int res)
 
 	pcf50633_mbc_usb_curlim_set(pcf, ma);
 }
+#endif
 
 static struct delayed_work gta02_charger_work;
 static int gta02_usb_vbus_draw;
-- 
2.7.0

  parent reply	other threads:[~2016-01-29 14:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1454079040-3567945-1-git-send-email-arnd@arndb.de>
2016-01-29 14:50 ` [PATCH 1/6] ARM: s3c24xx: don't select EEPROM_AT24 Arnd Bergmann
2016-02-01  0:40   ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 2/6] ARM: s3c24xx: allow selecting S3C2440_XTAL_16934400 for s3c2442 Arnd Bergmann
2016-02-01  0:46   ` Krzysztof Kozlowski
2016-01-29 14:50 ` Arnd Bergmann [this message]
2016-02-01  0:49   ` [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled Arnd Bergmann
2016-02-01  0:59   ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 5/6] ARM: s3c64xx: mark regulator init data as unused Arnd Bergmann
2016-02-01  1:18   ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 6/6] ARM: exynos: select THERMAL_OF Arnd Bergmann
2016-02-01  1:26   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454079040-3567945-4-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome