From: Chen-Yu Tsai <wens@csie.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH 0/2] clk: sunxi: Fix APBS clock for Allwinner A80
Date: Mon, 1 Feb 2016 22:42:47 +0800 [thread overview]
Message-ID: <1454337769-4130-1-git-send-email-wens@csie.org> (raw)
Hi everyone,
When I did the A80 PRCM support, I failed to notice the A80's APBS clock
was not the same as the A23's APB0 clock. The former is a zero-based
divider, while the latter is a power-of-two divider. But the lowest 2
dividers are the same.
The hardware defaults to the lowest setting, or a /1 divider. Since the
child gates do not propagate clk_set_rate up, and no consumers here do
clk_set_rate, this actually works.
I realized my mistake while reviewing the A83T's PRCM patches. The A83T
shares the same PRCM clocks as the A80.
Regards
ChenYu
Chen-Yu Tsai (2):
clk: sunxi: Add support for A80 APBS clock
ARM: dts: sun9i: Fix apbs clock compatible
Documentation/devicetree/bindings/clock/sunxi.txt | 1 +
arch/arm/boot/dts/sun9i-a80.dtsi | 2 +-
drivers/clk/sunxi/Makefile | 2 +-
drivers/clk/sunxi/clk-sun9i-apbs.c | 64 +++++++++++++++++++++++
4 files changed, 67 insertions(+), 2 deletions(-)
create mode 100644 drivers/clk/sunxi/clk-sun9i-apbs.c
--
2.7.0
next reply other threads:[~2016-02-01 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 14:42 Chen-Yu Tsai [this message]
2016-02-01 14:42 ` [PATCH 1/2] clk: sunxi: Add support for A80 APBS clock Chen-Yu Tsai
2016-02-01 14:57 ` Rob Herring
2016-02-02 11:15 ` Maxime Ripard
2016-02-10 3:25 ` Chen-Yu Tsai
2016-02-01 14:42 ` [PATCH 2/2] ARM: dts: sun9i: Fix apbs clock compatible Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454337769-4130-1-git-send-email-wens@csie.org \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®