From: Michael Ellerman <mpe@ellerman.id.au>
To: Luis Henriques <luis.henriques@canonical.com>,
Geoff Levand <geoff@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: Joe Perches <joe@perches.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs
Date: Tue, 09 Feb 2016 13:54:12 +1100 [thread overview]
Message-ID: <1454986452.17393.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1454970427-23017-1-git-send-email-luis.henriques@canonical.com>
On Mon, 2016-02-08 at 22:27 +0000, Luis Henriques wrote:
> Several network-related data structures are defined in gelic_udbg.
> These could be easily dropped and the standard ones defined in network
> headers could be used instead.
>
> The 4 patches that follow replace ethernet, vlan, ip and udp
> structures in gelic_udbg. Note that this has been compile-tested
> only.
>
> Changes since v1:
> Include changes suggested by Joe Perches, namely the usage of
> eth_broadcast_addr(), ETH_ALEN, ETH_P_8021Q and ETH_P_IP.
>
> Luis Henriques (4):
> powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h>
> powerpc/ps3: gelic_udbg: use struct vlan_hdr from <linux/if_vlan.h>
> powerpc/ps3: gelic_udbg: use struct iphdr from <linux/ip.h>
> powerpc/ps3: gelic_udbg: use struct udphdr from <linux/udp.h>
These look good. But I don't have a setup to test them, does anyone?
I'll merge them and hopefully someone can test them at some point.
cheers
prev parent reply other threads:[~2016-02-09 2:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 22:27 Luis Henriques
2016-02-08 22:27 ` [PATCH v2 1/4] powerpc/ps3: gelic_udbg: use struct ethhdr from <linux/if_ether.h> Luis Henriques
2016-03-01 22:21 ` [v2, " Michael Ellerman
2016-02-08 22:27 ` [PATCH v2 2/4] powerpc/ps3: gelic_udbg: use struct vlan_hdr from <linux/if_vlan.h> Luis Henriques
2016-02-08 22:27 ` [PATCH v2 3/4] powerpc/ps3: gelic_udbg: use struct iphdr from <linux/ip.h> Luis Henriques
2016-02-08 22:27 ` [PATCH v2 4/4] powerpc/ps3: gelic_udbg: use struct udphdr from <linux/udp.h> Luis Henriques
2016-02-09 2:54 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454986452.17393.1.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=geoff@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luis.henriques@canonical.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®