* [PATCH -next] drm/imagination: Use memdup_user() helper to simplify code
@ 2024-08-31 10:29 Jinjie Ruan
2024-09-02 7:59 ` Frank Binns
2024-09-02 9:20 ` Matt Coster
0 siblings, 2 replies; 3+ messages in thread
From: Jinjie Ruan @ 2024-08-31 10:29 UTC (permalink / raw)
To: frank.binns, matt.coster, maarten.lankhorst, mripard,
tzimmermann, airlied, daniel, dri-devel, linux-kernel
Cc: ruanjinjie
Switching to memdup_user(), which combines kmalloc() and copy_from_user(),
and it can simplfy code.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/gpu/drm/imagination/pvr_job.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/imagination/pvr_job.c b/drivers/gpu/drm/imagination/pvr_job.c
index 78c2f3c6dce0..618503a212a7 100644
--- a/drivers/gpu/drm/imagination/pvr_job.c
+++ b/drivers/gpu/drm/imagination/pvr_job.c
@@ -90,20 +90,13 @@ static int pvr_fw_cmd_init(struct pvr_device *pvr_dev, struct pvr_job *job,
void *stream;
int err;
- stream = kzalloc(stream_len, GFP_KERNEL);
- if (!stream)
- return -ENOMEM;
-
- if (copy_from_user(stream, u64_to_user_ptr(stream_userptr), stream_len)) {
- err = -EFAULT;
- goto err_free_stream;
- }
+ stream = memdup_user(u64_to_user_ptr(stream_userptr), stream_len);
+ if (IS_ERR(stream))
+ return PTR_ERR(stream);
err = pvr_job_process_stream(pvr_dev, stream_def, stream, stream_len, job);
-err_free_stream:
kfree(stream);
-
return err;
}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/imagination: Use memdup_user() helper to simplify code
2024-08-31 10:29 [PATCH -next] drm/imagination: Use memdup_user() helper to simplify code Jinjie Ruan
@ 2024-09-02 7:59 ` Frank Binns
2024-09-02 9:20 ` Matt Coster
1 sibling, 0 replies; 3+ messages in thread
From: Frank Binns @ 2024-09-02 7:59 UTC (permalink / raw)
To: tzimmermann, Matt Coster, dri-devel, airlied, linux-kernel,
maarten.lankhorst, ruanjinjie, daniel, mripard
On Sat, 2024-08-31 at 18:29 +0800, Jinjie Ruan wrote:
> Switching to memdup_user(), which combines kmalloc() and copy_from_user(),
> and it can simplfy code.
>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> drivers/gpu/drm/imagination/pvr_job.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/imagination/pvr_job.c b/drivers/gpu/drm/imagination/pvr_job.c
> index 78c2f3c6dce0..618503a212a7 100644
> --- a/drivers/gpu/drm/imagination/pvr_job.c
> +++ b/drivers/gpu/drm/imagination/pvr_job.c
> @@ -90,20 +90,13 @@ static int pvr_fw_cmd_init(struct pvr_device *pvr_dev, struct pvr_job *job,
> void *stream;
> int err;
>
> - stream = kzalloc(stream_len, GFP_KERNEL);
> - if (!stream)
> - return -ENOMEM;
> -
> - if (copy_from_user(stream, u64_to_user_ptr(stream_userptr), stream_len)) {
> - err = -EFAULT;
> - goto err_free_stream;
> - }
> + stream = memdup_user(u64_to_user_ptr(stream_userptr), stream_len);
> + if (IS_ERR(stream))
> + return PTR_ERR(stream);
>
> err = pvr_job_process_stream(pvr_dev, stream_def, stream, stream_len, job);
>
> -err_free_stream:
> kfree(stream);
> -
> return err;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/imagination: Use memdup_user() helper to simplify code
2024-08-31 10:29 [PATCH -next] drm/imagination: Use memdup_user() helper to simplify code Jinjie Ruan
2024-09-02 7:59 ` Frank Binns
@ 2024-09-02 9:20 ` Matt Coster
1 sibling, 0 replies; 3+ messages in thread
From: Matt Coster @ 2024-09-02 9:20 UTC (permalink / raw)
To: Jinjie Ruan, Frank Binns, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 308 bytes --]
On 31/08/2024 11:29, Jinjie Ruan wrote:
> Switching to memdup_user(), which combines kmalloc() and copy_from_user(),
> and it can simplfy code.
Applied, thanks!
[1/1] drm/imagination: Use memdup_user() helper to simplify code
commit: 3742c20958a5b02ecba08d71036bae3e7b9d21b3
Cheers,
Matt
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-02 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-31 10:29 [PATCH -next] drm/imagination: Use memdup_user() helper to simplify code Jinjie Ruan
2024-09-02 7:59 ` Frank Binns
2024-09-02 9:20 ` Matt Coster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®