* [PATCH 1/2] regulator: qcom_saw: Fix testing wrong value
@ 2016-02-11 4:57 Axel Lin
2016-02-11 4:58 ` [PATCH 2/2] regulator: qcom_saw: Fix uninitialized variable build warning Axel Lin
2016-02-19 16:21 ` [PATCH 1/2] regulator: qcom_saw: Fix testing wrong value Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2016-02-11 4:57 UTC (permalink / raw)
To: Mark Brown; +Cc: Georgi Djakov, Liam Girdwood, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/qcom_saw-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/qcom_saw-regulator.c b/drivers/regulator/qcom_saw-regulator.c
index c800f16..c00f0df 100644
--- a/drivers/regulator/qcom_saw-regulator.c
+++ b/drivers/regulator/qcom_saw-regulator.c
@@ -186,8 +186,8 @@ static int qcom_saw_regulator_probe(struct platform_device *pdev)
vreg->regmap = syscon_node_to_regmap(saw_np);
of_node_put(saw_np);
- if (IS_ERR(config.regmap))
- return PTR_ERR(config.regmap);
+ if (IS_ERR(vreg->regmap))
+ return PTR_ERR(vreg->regmap);
snprintf(name, sizeof(name), "krait%d", cpu);
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] regulator: qcom_saw: Fix uninitialized variable build warning
2016-02-11 4:57 [PATCH 1/2] regulator: qcom_saw: Fix testing wrong value Axel Lin
@ 2016-02-11 4:58 ` Axel Lin
2016-02-19 16:21 ` [PATCH 1/2] regulator: qcom_saw: Fix testing wrong value Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Axel Lin @ 2016-02-11 4:58 UTC (permalink / raw)
To: Mark Brown; +Cc: Georgi Djakov, Liam Girdwood, linux-kernel
Fix below build warning:
CC [M] drivers/regulator/qcom_saw-regulator.o
drivers/regulator/qcom_saw-regulator.c: In function 'qcom_saw_regulator_probe':
drivers/regulator/qcom_saw-regulator.c:154:5: warning: 'found' is used uninitialized in this function [-Wuninitialized]
drivers/regulator/qcom_saw-regulator.c:140:7: note: 'found' was declared here
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/qcom_saw-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/qcom_saw-regulator.c b/drivers/regulator/qcom_saw-regulator.c
index c00f0df..6751614 100644
--- a/drivers/regulator/qcom_saw-regulator.c
+++ b/drivers/regulator/qcom_saw-regulator.c
@@ -137,7 +137,7 @@ static struct saw_vreg *saw_get_drv(struct platform_device *pdev,
struct saw_vreg *vreg = NULL;
struct device_node *cpu_node, *saw_node;
int cpu;
- bool found;
+ bool found = false;
for_each_possible_cpu(cpu) {
cpu_node = of_cpu_device_node_get(cpu);
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] regulator: qcom_saw: Fix testing wrong value
2016-02-11 4:57 [PATCH 1/2] regulator: qcom_saw: Fix testing wrong value Axel Lin
2016-02-11 4:58 ` [PATCH 2/2] regulator: qcom_saw: Fix uninitialized variable build warning Axel Lin
@ 2016-02-19 16:21 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2016-02-19 16:21 UTC (permalink / raw)
To: Axel Lin; +Cc: Georgi Djakov, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
On Thu, Feb 11, 2016 at 12:57:21PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
I'm going to drop this driver so these patches are no longer required.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-20 17:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-11 4:57 [PATCH 1/2] regulator: qcom_saw: Fix testing wrong value Axel Lin
2016-02-11 4:58 ` [PATCH 2/2] regulator: qcom_saw: Fix uninitialized variable build warning Axel Lin
2016-02-19 16:21 ` [PATCH 1/2] regulator: qcom_saw: Fix testing wrong value Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®