From: Joe Perches <joe@perches.com>
To: James Simmons <jsimmons@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Dorkin <oleg.dorkin@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 06/11] staging: lustre: add missing spaces for LNet layer reported by checkpatch.pl
Date: Fri, 12 Feb 2016 09:35:03 -0800 [thread overview]
Message-ID: <1455298503.4235.4.camel@perches.com> (raw)
In-Reply-To: <1455296769-5481-7-git-send-email-jsimmons@infradead.org>
On Fri, 2016-02-12 at 12:06 -0500, James Simmons wrote:
> Add missing spaces in the code reported by checkpatch.pl.
[]
> diff --git a/drivers/staging/lustre/include/linux/lnet/lib-types.h b/drivers/staging/lustre/include/linux/lnet/lib-types.h
[]
> @@ -112,7 +112,7 @@ typedef struct lnet_libhandle {
> } lnet_libhandle_t;
>
> #define lh_entry(ptr, type, member) \
> - ((type *)((char *)(ptr)-(char *)(&((type *)0)->member)))
> + ((type *)((char *)(ptr) - (char *)(&((type *)0)->member)))
This could use offsetof(type, member)
next prev parent reply other threads:[~2016-02-12 17:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 17:05 [PATCH 00/11] Massive style cleanup for LNet layer James Simmons
2016-02-12 17:05 ` [PATCH 01/11] staging: lustre: drop *_t from end of struct lnet_text_buf James Simmons
2016-02-12 17:06 ` [PATCH 02/11] staging: lustre: format properly all comment blocks for LNet core James Simmons
2016-02-12 17:06 ` [PATCH 03/11] staging: lustre: align all code properly " James Simmons
2016-02-12 17:06 ` [PATCH 04/11] staging: lustre: remove unnecessary parentheses around LNet function pointer James Simmons
2016-02-12 17:06 ` [PATCH 05/11] staging: lustre: remove unnecessary blank lines reported by checkpatch.pl James Simmons
2016-02-12 17:06 ` [PATCH 06/11] staging: lustre: add missing spaces for LNet layer " James Simmons
2016-02-12 17:35 ` Joe Perches [this message]
2016-02-12 23:20 ` [lustre-devel] " Simmons, James A.
2016-02-12 17:06 ` [PATCH 07/11] staging: lustre: don't set more than one variable per line in LNet layer James Simmons
2016-02-12 17:06 ` [PATCH 08/11] staging: lustre: remove space in LNet function declarations James Simmons
2016-02-12 17:06 ` [PATCH 09/11] staging: lustre: balance braces properly in LNet layer James Simmons
2016-02-12 17:06 ` [PATCH 10/11] staging: lustre: fix all NULL comparisons " James Simmons
2016-02-12 17:06 ` [PATCH 11/11] staging: lustre: fix all conditional comparison to zero " James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455298503.4235.4.camel@perches.com \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.dorkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®