From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Greg KH <greg@kroah.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Chunyan Zhang <zhang.chunyan@linaro.org>,
laurent.fert@intel.com, yann.fouassier@intel.com,
linux-kernel@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [PATCH 12/20] stm class: Support devices with multiple instances
Date: Mon, 15 Feb 2016 19:12:02 +0200 [thread overview]
Message-ID: <1455556330-12473-13-git-send-email-alexander.shishkin@linux.intel.com> (raw)
In-Reply-To: <1455556330-12473-1-git-send-email-alexander.shishkin@linux.intel.com>
By convention, the name of the stm policy directory in configfs consists of
the device name to which it applies and the actual policy name, separated
by a dot. Now, some devices already have dots in their names that separate
name of the actual device from its instance identifier. Such devices will
result in two (or more, who can tell) dots in the policy directory name.
Existing policy code, however, will treat the first dot as the one that
separates device name from policy name, therefore failing the above case.
This patch makes the last dot in the directory name be the separator, thus
prohibiting dots from being used in policy names.
Suggested-by: Chunyan Zhang <zhang.chunyan@linaro.org>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
drivers/hwtracing/stm/policy.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/hwtracing/stm/policy.c b/drivers/hwtracing/stm/policy.c
index 94d3abfb73..1db189657b 100644
--- a/drivers/hwtracing/stm/policy.c
+++ b/drivers/hwtracing/stm/policy.c
@@ -332,10 +332,11 @@ stp_policies_make(struct config_group *group, const char *name)
/*
* node must look like <device_name>.<policy_name>, where
- * <device_name> is the name of an existing stm device and
- * <policy_name> is an arbitrary string
+ * <device_name> is the name of an existing stm device; may
+ * contain dots;
+ * <policy_name> is an arbitrary string; may not contain dots
*/
- p = strchr(devname, '.');
+ p = strrchr(devname, '.');
if (!p) {
kfree(devname);
return ERR_PTR(-EINVAL);
--
2.7.0
next prev parent reply other threads:[~2016-02-15 17:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 16:08 [git pull] stm class/intel_th: Updates for char-misc-next Alexander Shishkin
2016-02-15 16:44 ` Greg KH
2016-02-15 17:11 ` [PATCH 00/20] " Alexander Shishkin
2016-02-15 17:11 ` [PATCH 01/20] stm class: Use a signed return type for stm_find_master_chan Alexander Shishkin
2016-02-15 17:11 ` [PATCH 02/20] stm class: Fix master deallocation in device unregistering Alexander Shishkin
2016-02-15 17:11 ` [PATCH 03/20] intel_th: Depend on HAS_IOMEM Alexander Shishkin
2016-02-15 17:11 ` [PATCH 04/20] intel_th: gth: Remove commented-out code Alexander Shishkin
2016-02-15 17:11 ` [PATCH 05/20] intel_th: Update scratchpad bits according to enabled output activity Alexander Shishkin
2016-02-15 17:11 ` [PATCH 06/20] intel_th: msu: Fix offset for wrapped block Alexander Shishkin
2016-02-15 17:11 ` [PATCH 07/20] intel_th: msu: Release resources on read error Alexander Shishkin
2016-02-15 17:11 ` [PATCH 08/20] intel_th: sth: Sanitize packet callback's return values Alexander Shishkin
2016-02-15 17:11 ` [PATCH 09/20] intel_th: Set root device's drvdata early Alexander Shishkin
2016-02-15 17:12 ` [PATCH 10/20] intel_th: Use real device index in the node names Alexander Shishkin
2016-02-15 17:12 ` [PATCH 11/20] stm class: Use driver's packet callback return value Alexander Shishkin
2016-02-15 17:12 ` Alexander Shishkin [this message]
2016-02-15 17:12 ` [PATCH 13/20] stm class: dummy_stm: Create multiple devices Alexander Shishkin
2016-02-15 17:12 ` [PATCH 14/20] stm class: Add heartbeat stm source device Alexander Shishkin
2016-02-15 17:12 ` [PATCH 15/20] stm class: Fix unlocking braino in the error path Alexander Shishkin
2016-02-15 17:12 ` [PATCH 16/20] stm class: Guard output assignment against concurrency Alexander Shishkin
2016-02-15 17:12 ` [PATCH 17/20] stm class: Fix unbalanced module/device refcounting Alexander Shishkin
2016-02-15 17:12 ` [PATCH 18/20] stm class: Fix a race in unlinking Alexander Shishkin
2016-02-15 17:12 ` [PATCH 19/20] stm class: Plug stm device's unlink callback Alexander Shishkin
2016-02-15 17:12 ` [PATCH 20/20] stm class: dummy_stm: Add link callback for fault injection Alexander Shishkin
2016-02-16 12:29 ` [git pull] stm class/intel_th: Updates for char-misc-next Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455556330-12473-13-git-send-email-alexander.shishkin@linux.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=greg@kroah.com \
--cc=laurent.fert@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=yann.fouassier@intel.com \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome