mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v4 1/4] Staging: rtl8188eu/core: remove paragraph which mention FSF address in comment header
@ 2016-02-16 22:12 Colin Vidal
  2016-02-16 22:12 ` [PATCH v4 2/4] Staging: rtl8188eu/core: Coding style fix, set conform spaces between identifiers Colin Vidal
  0 siblings, 1 reply; 4+ messages in thread
From: Colin Vidal @ 2016-02-16 22:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman, open list:STAGING SUBSYSTEM, open list; +Cc: Colin Vidal

As FSF address changed in the past, and can change in the future,
remove the address paragraph in the comment header, and avoid a warning
of checkpatch.

Signed-off-by: Colin Vidal <colin@cvidal.org>
---
 drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c
index cdcf0ea..000a81c 100644
--- a/drivers/staging/rtl8188eu/core/rtw_iol.c
+++ b/drivers/staging/rtl8188eu/core/rtw_iol.c
@@ -11,10 +11,6 @@
  * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
  * more details.
  *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
  *
  ******************************************************************************/
 
-- 
2.5.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v4 2/4] Staging: rtl8188eu/core: Coding style fix, set conform spaces between identifiers
  2016-02-16 22:12 [PATCH v4 1/4] Staging: rtl8188eu/core: remove paragraph which mention FSF address in comment header Colin Vidal
@ 2016-02-16 22:12 ` Colin Vidal
  2016-02-16 22:12   ` [PATCH v4 3/4] Staging: rtl8188eu/core: Coding style fix, set constant operand on right in tests Colin Vidal
  0 siblings, 1 reply; 4+ messages in thread
From: Colin Vidal @ 2016-02-16 22:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman, open list:STAGING SUBSYSTEM, open list; +Cc: Colin Vidal

And a space after include keyword, making the preprocessor more
readable, and remove an unexpected space between a type and variable
name.

Signed-off-by: Colin Vidal <colin@cvidal.org>
---
 drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c
index 000a81c..7642c22 100644
--- a/drivers/staging/rtl8188eu/core/rtw_iol.c
+++ b/drivers/staging/rtl8188eu/core/rtw_iol.c
@@ -14,9 +14,9 @@
  *
  ******************************************************************************/
 
-#include<rtw_iol.h>
+#include <rtw_iol.h>
 
-bool rtw_IOL_applied(struct adapter  *adapter)
+bool rtw_IOL_applied(struct adapter *adapter)
 {
 	if (1 == adapter->registrypriv.fw_iol)
 		return true;
-- 
2.5.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v4 3/4] Staging: rtl8188eu/core: Coding style fix, set constant operand on right in tests
  2016-02-16 22:12 ` [PATCH v4 2/4] Staging: rtl8188eu/core: Coding style fix, set conform spaces between identifiers Colin Vidal
@ 2016-02-16 22:12   ` Colin Vidal
  2016-02-16 22:12     ` [PATCH v4 4/4] Staging: rtl8188eu/core: Coding style fix, avoid line over 80 characters Colin Vidal
  0 siblings, 1 reply; 4+ messages in thread
From: Colin Vidal @ 2016-02-16 22:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman, open list:STAGING SUBSYSTEM, open list; +Cc: Colin Vidal

Remove a checkpatch warning, putting constant operant on right of two tests.

Signed-off-by: Colin Vidal <colin@cvidal.org>
---
 drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c
index 7642c22..3dd1a9a 100644
--- a/drivers/staging/rtl8188eu/core/rtw_iol.c
+++ b/drivers/staging/rtl8188eu/core/rtw_iol.c
@@ -18,10 +18,10 @@
 
 bool rtw_IOL_applied(struct adapter *adapter)
 {
-	if (1 == adapter->registrypriv.fw_iol)
+	if (adapter->registrypriv.fw_iol == 1)
 		return true;
 
-	if ((2 == adapter->registrypriv.fw_iol) && (!adapter_to_dvobj(adapter)->ishighspeed))
+	if ((adapter->registrypriv.fw_iol == 2) && (!adapter_to_dvobj(adapter)->ishighspeed))
 		return true;
 	return false;
 }
-- 
2.5.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v4 4/4] Staging: rtl8188eu/core: Coding style fix, avoid line over 80 characters
  2016-02-16 22:12   ` [PATCH v4 3/4] Staging: rtl8188eu/core: Coding style fix, set constant operand on right in tests Colin Vidal
@ 2016-02-16 22:12     ` Colin Vidal
  0 siblings, 0 replies; 4+ messages in thread
From: Colin Vidal @ 2016-02-16 22:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman, open list:STAGING SUBSYSTEM, open list; +Cc: Colin Vidal

Jump a new line after and operator of the test. It avoids to exceed 80
chars line, and remove a checkpatch warning.

Signed-off-by: Colin Vidal <colin@cvidal.org>
---
 drivers/staging/rtl8188eu/core/rtw_iol.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c
index 3dd1a9a..2e2145c 100644
--- a/drivers/staging/rtl8188eu/core/rtw_iol.c
+++ b/drivers/staging/rtl8188eu/core/rtw_iol.c
@@ -21,7 +21,8 @@ bool rtw_IOL_applied(struct adapter *adapter)
 	if (adapter->registrypriv.fw_iol == 1)
 		return true;
 
-	if ((adapter->registrypriv.fw_iol == 2) && (!adapter_to_dvobj(adapter)->ishighspeed))
+	if ((adapter->registrypriv.fw_iol == 2) &&
+	    (!adapter_to_dvobj(adapter)->ishighspeed))
 		return true;
 	return false;
 }
-- 
2.5.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-02-16 22:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-16 22:12 [PATCH v4 1/4] Staging: rtl8188eu/core: remove paragraph which mention FSF address in comment header Colin Vidal
2016-02-16 22:12 ` [PATCH v4 2/4] Staging: rtl8188eu/core: Coding style fix, set conform spaces between identifiers Colin Vidal
2016-02-16 22:12   ` [PATCH v4 3/4] Staging: rtl8188eu/core: Coding style fix, set constant operand on right in tests Colin Vidal
2016-02-16 22:12     ` [PATCH v4 4/4] Staging: rtl8188eu/core: Coding style fix, avoid line over 80 characters Colin Vidal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®