From: Valentin Rothberg <valentin.rothberg@posteo.net>
To: ldewangan@nvidia.com
Cc: kbuild-all@01.org, alexandre.belloni@free-electrons.com,
javier@osg.samsung.com, k.kozlowski@samsung.com,
cw00.choi@samsung.com, a.zummo@towertech.it,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
kbuild test robot <fengguang.wu@intel.com>,
Valentin Rothberg <valentin.rothberg@posteo.net>
Subject: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings
Date: Thu, 18 Feb 2016 09:06:56 +0100 [thread overview]
Message-ID: <1455782816-5814-1-git-send-email-valentin.rothberg@posteo.net> (raw)
From: kbuild test robot <fengguang.wu@intel.com>
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
CC: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Valentin Rothberg <valentin.rothberg@posteo.net>
---
drivers/rtc/rtc-max77686.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index 5e924f3cde90..027ee7ebfff4 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -742,8 +742,8 @@ static int max77686_rtc_probe(struct platform_device *pdev)
goto err_rtc;
}
- ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0,
- "rtc-alarm1", info);
+ ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq,
+ IRQF_ONESHOT, "rtc-alarm1", info);
if (ret < 0) {
dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
info->virq, ret);
--
2.5.0
next reply other threads:[~2016-02-18 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 8:06 Valentin Rothberg [this message]
2016-02-18 8:13 ` Krzysztof Kozlowski
2016-02-18 8:46 ` Valentin Rothberg
2016-02-18 8:50 ` Krzysztof Kozlowski
2016-02-18 9:03 ` Valentin Rothberg
2016-02-18 8:51 ` Alexandre Belloni
2016-02-18 9:23 ` Valentin Rothberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455782816-5814-1-git-send-email-valentin.rothberg@posteo.net \
--to=valentin.rothberg@posteo.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=cw00.choi@samsung.com \
--cc=fengguang.wu@intel.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kbuild-all@01.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®