From: Wolfram Sang <wsa@the-dreams.de>
To: platform-driver-x86@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
Alex Hung <alex.hung@canonical.com>,
Darren Hart <dvhart@infradead.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] intel-hid: allocate correct amount of memory for private struct
Date: Sun, 21 Feb 2016 15:22:27 +0100 [thread overview]
Message-ID: <1456064574-11245-1-git-send-email-wsa@the-dreams.de> (raw)
We want the size of the struct, not of a pointer to it. To be future
proof, just dereference the pointer to get the desired type.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Compile tested only. Found by static code analysis.
drivers/platform/x86/intel-hid.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
index e20f23e04c24ce..f93abc8c1424ad 100644
--- a/drivers/platform/x86/intel-hid.c
+++ b/drivers/platform/x86/intel-hid.c
@@ -180,8 +180,7 @@ static int intel_hid_probe(struct platform_device *device)
return -ENODEV;
}
- priv = devm_kzalloc(&device->dev,
- sizeof(struct intel_hid_priv *), GFP_KERNEL);
+ priv = devm_kzalloc(&device->dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
dev_set_drvdata(&device->dev, priv);
--
2.7.0
next reply other threads:[~2016-02-21 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 14:22 Wolfram Sang [this message]
2016-02-22 22:27 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456064574-11245-1-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=alex.hung@canonical.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®