mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@ezchip.com>
To: Russell King <linux@arm.linux.org.uk>,
	Thomas Gleixner <tglx@linutronix.de>,
	Aaron Tomlin <atomlin@redhat.com>, Ingo Molnar <mingo@redhat.com>,
	Andrew Morton <akpm@osdl.org>,
	Daniel Thompson <daniel.thompson@linaro.org>, <x86@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Cc: Chris Metcalf <cmetcalf@ezchip.com>
Subject: [PATCH 0/4] improvements to the nmi_backtrace code
Date: Mon, 29 Feb 2016 16:40:20 -0500	[thread overview]
Message-ID: <1456782024-7122-1-git-send-email-cmetcalf@ezchip.com> (raw)

This patch series modifies the trigger_xxx_backtrace() NMI-based
remote backtracing code to make it more flexible, and makes a few
small improvements along the way.

The motivation comes from the task isolation code, where there are
scenarios where we want to be able to diagnose a case where some cpu
is about to interrupt a task-isolated cpu.  It can be helpful to
see both where the interrupting cpu is, and also an approximation
of where the cpu that is being interrupted is.  The nmi_backtrace
framework allows us to discover the stack of the interrupted cpu.

The first change adds support for trigger_single_cpu_backtrace(), and
as an "API side-effect", trigger_cpumask_backtrace().  The underlying
abstraction is changed to use cpumasks instead of a "bool except_self".

The second and third changes provide small improvements to the
behavior of the existing nmi_backtrace code: omitting full backtrace
dumps for idle cores, and doing local dump_stack backtraces when we
try to do a "remote" dump of the local core.  Some of this reflects
changes from integrating the arch/tile code into the generic code.

The fourth change hooks the arch/tile backtrace mechanism into
the nmi_backtrace code to share code and take advantage of other
improvements of nmi_backtrace not present in the original arch/tile
code, like co-opting printk to use local buffers instead of just
spewing to the console and hoping for the best.

The changes have been runtime tested on tile, and build-tested on
x86 and arm.

Chris Metcalf (4):
  nmi_backtrace: add more trigger_*_cpu_backtrace() methods
  nmi_backtrace: generate one-line reports for idle cpus
  nmi_backtrace: do a local dump_stack() instead of a self-NMI
  arch/tile: adopt the new nmi_backtrace framework

 arch/arm/include/asm/irq.h    |  4 +--
 arch/arm/kernel/smp.c         | 13 ++------
 arch/tile/include/asm/irq.h   |  4 +--
 arch/tile/kernel/pmc.c        |  3 --
 arch/tile/kernel/process.c    | 72 ++++++++++---------------------------------
 arch/tile/kernel/traps.c      |  7 +++--
 arch/x86/include/asm/irq.h    |  4 +--
 arch/x86/kernel/apic/hw_nmi.c |  6 ++--
 include/linux/nmi.h           | 63 +++++++++++++++++++++++++++++--------
 lib/nmi_backtrace.c           | 48 ++++++++++++++++++++---------
 10 files changed, 116 insertions(+), 108 deletions(-)

-- 
2.1.2

             reply	other threads:[~2016-02-29 23:13 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 21:40 Chris Metcalf [this message]
2016-02-29 21:40 ` [PATCH 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-02-29 21:40 ` [PATCH 2/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-03-01 14:23   ` Daniel Thompson
2016-03-01 16:01     ` Chris Metcalf
2016-03-07  8:26       ` Daniel Thompson
2016-03-07 17:05         ` Chris Metcalf
2016-03-07  9:48       ` Peter Zijlstra
2016-03-07 17:38         ` Chris Metcalf
2016-03-07 20:43           ` Peter Zijlstra
2016-03-16 17:02             ` [PATCH v2 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-03-16 17:02               ` [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-03-17 19:36                 ` Peter Zijlstra
2016-03-17 22:31                   ` Chris Metcalf
2016-03-17 22:38                     ` Peter Zijlstra
2016-03-17 22:41                       ` Chris Metcalf
2016-03-17 23:14                         ` Peter Zijlstra
2016-03-17 22:55                   ` Paul E. McKenney
2016-03-17 23:09                     ` Peter Zijlstra
2016-03-17 23:11                     ` Peter Zijlstra
2016-03-18  0:28                       ` Paul E. McKenney
2016-03-18  0:17                     ` Chris Metcalf
2016-03-18  0:33                       ` Paul E. McKenney
2016-03-18  9:40                         ` Daniel Thompson
2016-03-18 23:54                           ` Paul E. McKenney
2016-03-16 17:02               ` [PATCH v2 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-03-16 17:02               ` [PATCH v2 3/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-03-16 17:02               ` [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-03-16 18:46                 ` kbuild test robot
2016-03-21 15:38                 ` Peter Zijlstra
2016-03-21 15:46                   ` Chris Metcalf
2016-03-21 15:42                 ` Peter Zijlstra
2016-03-21 16:15                   ` Chris Metcalf
2016-03-21 16:32                     ` Peter Zijlstra
2016-03-21 17:12                       ` Chris Metcalf
2016-03-21 17:17                         ` Peter Zijlstra
2016-03-21 16:48                 ` Peter Zijlstra
2016-03-21 21:49                 ` Peter Zijlstra
2016-03-22 17:19                   ` [PATCH v3 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-03-22 17:19                     ` [PATCH v3 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-03-22 17:19                     ` [PATCH v3 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-03-22 17:19                     ` [PATCH v3 3/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-03-22 17:19                     ` [PATCH v3 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-03-22 17:30                       ` Peter Zijlstra
2016-03-22 22:28                         ` Rafael J. Wysocki
2016-03-22 22:31                       ` Rafael J. Wysocki
2016-03-22 22:45                         ` Peter Zijlstra
2016-03-23  0:50                           ` Rafael J. Wysocki
2016-03-23  7:53                             ` Peter Zijlstra
2016-03-30 17:16                             ` [PATCH v4 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-03-30 17:16                               ` [PATCH v4 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-03-30 17:16                               ` [PATCH v4 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-03-30 17:16                               ` [PATCH v4 3/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-03-30 17:16                               ` [PATCH v4 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-02-29 21:40 ` [PATCH 3/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-02-29 21:40 ` [PATCH 4/4] arch/tile: adopt the new nmi_backtrace framework Chris Metcalf
2016-03-01  0:49 ` [PATCH 0/4] improvements to the nmi_backtrace code Andrew Morton
2016-03-01 10:01   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456782024-7122-1-git-send-email-cmetcalf@ezchip.com \
    --to=cmetcalf@ezchip.com \
    --cc=akpm@osdl.org \
    --cc=atomlin@redhat.com \
    --cc=daniel.thompson@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®