mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] misc: sram: fix check of devm_ioremap_wc() return value
@ 2016-03-07  0:41 Vladimir Zapolskiy
  0 siblings, 0 replies; only message in thread
From: Vladimir Zapolskiy @ 2016-03-07  0:41 UTC (permalink / raw)
  To: Arnd Bergmann, Greg Kroah-Hartman; +Cc: Abhilash Kesavan, linux-kernel

The devm_ioremap_wc() function returns either a valid pointer to iomem
region or NULL, check for IS_ERR() is bogus.

The problem was introduced by commit 0ab163ad1ea0 ("misc: sram: switch
to ioremap_wc from ioremap") and it survived after the recent MMIO
SRAM driver refactoring.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
 drivers/misc/sram.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c
index 736dae7..9174623 100644
--- a/drivers/misc/sram.c
+++ b/drivers/misc/sram.c
@@ -361,8 +361,8 @@ static int sram_probe(struct platform_device *pdev)
 	}
 
 	sram->virt_base = devm_ioremap_wc(sram->dev, res->start, size);
-	if (IS_ERR(sram->virt_base))
-		return PTR_ERR(sram->virt_base);
+	if (!sram->virt_base)
+		return -ENOMEM;
 
 	sram->pool = devm_gen_pool_create(sram->dev, ilog2(SRAM_GRANULARITY),
 					  NUMA_NO_NODE, NULL);
-- 
2.1.4

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-03-07  0:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-07  0:41 [PATCH] misc: sram: fix check of devm_ioremap_wc() return value Vladimir Zapolskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®