mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mihai Mihalache <mihai.d.mihalache@intel.com>
To: linux-kernel@vger.kernel.org, broonie@kernel.org, lgirdwood@gmail.com
Cc: yousaf.kaukab@intel.com, hans.holmberg@intel.com,
	mihai.d.mihalache@intel.com
Subject: [PATCH v2] regulator: gpio: check return value of of_get_named_gpio
Date: Wed, 16 Mar 2016 08:21:12 -0700	[thread overview]
Message-ID: <1458141672-3303-1-git-send-email-mihai.d.mihalache@intel.com> (raw)

At boot time the regulator driver can be initialized before the
gpio, in which case the call to of_get_named_gpio will return
EPROBE_DEFER. This value is silently passed to regulator_register
which will return success, although the gpio is not registered
(regulator_ena_gpio_request not called) as the value passed is
detected as invalid. The gpio_regulator_probe will therefore
succeed win no gpio requested.

Signed-off-by: Mihai Mihalache <mihai.d.mihalache@intel.com>
Reviewed-by: Hans Holmberg <hans.holmberg@intel.com>
---

History:
	V1:
	- Fix comment from Mark Brown
	V2:
	- Explicit check for EPROBE_DEFER for optional property, 
	  Mark Brown's feedback.

 drivers/regulator/gpio-regulator.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 464018d..f3147ef 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -162,6 +162,8 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np,
 	of_property_read_u32(np, "startup-delay-us", &config->startup_delay);
 
 	config->enable_gpio = of_get_named_gpio(np, "enable-gpio", 0);
+	if (config->enable_gpio == -EPROBE_DEFER)
+		return ERR_PTR(-EPROBE_DEFER);
 
 	/* Fetch GPIOs. - optional property*/
 	ret = of_gpio_count(np);
-- 
2.1.4

             reply	other threads:[~2016-03-16 15:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 15:21 Mihai Mihalache [this message]
2016-03-17 11:45 ` Applied "regulator: gpio: check return value of of_get_named_gpio" to the regulator tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458141672-3303-1-git-send-email-mihai.d.mihalache@intel.com \
    --to=mihai.d.mihalache@intel.com \
    --cc=broonie@kernel.org \
    --cc=hans.holmberg@intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yousaf.kaukab@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®