mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: [PATCH 1/2] regulator: core: Always flag voltage constraints as appliable
Date: Mon, 21 Mar 2016 19:18:31 +0000	[thread overview]
Message-ID: <1458587912-32665-1-git-send-email-broonie@kernel.org> (raw)

Allow the core to always use the voltage constraints to set the voltage
on startup.  A forthcoming change in that code will ensure that we bring
out of constraints voltages into spec with this setting.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/of_regulator.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index 6b0aa80b22fd..d2ddefaaddaf 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -43,12 +43,10 @@ static void of_get_regulation_constraints(struct device_node *np,
 		constraints->max_uV = pval;
 
 	/* Voltage change possible? */
-	if (constraints->min_uV != constraints->max_uV)
+	if (constraints->min_uV != constraints->max_uV) {
 		constraints->valid_ops_mask |= REGULATOR_CHANGE_VOLTAGE;
-	/* Only one voltage?  Then make sure it's set. */
-	if (constraints->min_uV && constraints->max_uV &&
-	    constraints->min_uV == constraints->max_uV)
 		constraints->apply_uV = true;
+	}
 
 	if (!of_property_read_u32(np, "regulator-microvolt-offset", &pval))
 		constraints->uV_offset = pval;
-- 
2.7.0

             reply	other threads:[~2016-03-21 19:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 19:18 Mark Brown [this message]
2016-03-21 19:18 ` [PATCH 2/2] regulator: core: Ensure we are at least in bounds for our constraints Mark Brown
2016-03-21 21:06   ` Ivaylo Dimitrov
2016-03-24  6:11     ` Krzysztof Kozlowski
2016-03-24  7:18       ` Krzysztof Kozlowski
2016-03-26 23:50         ` Bjorn Andersson
2016-03-27  9:08           ` Mark Brown
2016-03-28 16:16             ` Bjorn Andersson
2016-03-29 12:00             ` Geert Uytterhoeven
2016-03-29 14:58               ` Mark Brown
2016-03-29 18:05                 ` Geert Uytterhoeven
2016-03-29 18:27                   ` Mark Brown
2016-03-30  9:07                     ` Haibo Chen
2016-03-30 15:25                       ` Mark Brown
2016-03-23 13:43   ` Applied "regulator: core: Ensure we are at least in bounds for our constraints" to the regulator tree Mark Brown
2016-03-23 13:43 ` Applied "regulator: core: Always flag voltage constraints as appliable" " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458587912-32665-1-git-send-email-broonie@kernel.org \
    --to=broonie@kernel.org \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®