mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Antony Pavlov <antonynpavlov@gmail.com>
Subject: [PATCH] MIPS: ath79: fix build failure
Date: Wed, 30 Mar 2016 16:29:49 +0100	[thread overview]
Message-ID: <1459351789-24544-1-git-send-email-sudipm.mukherjee@gmail.com> (raw)

The ath79_defconfig build of mips was faling with the errors:

arch/mips/ath79/setup.c: In function 'plat_mem_setup':
arch/mips/ath79/setup.c:226:20: error: invalid storage class for function 'ath79_of_plat_time_init'
 static void __init ath79_of_plat_time_init(void)
                    ^
arch/mips/ath79/setup.c:226:1: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
 static void __init ath79_of_plat_time_init(void)
 ^
arch/mips/ath79/setup.c:284:20: error: invalid storage class for function 'ath79_setup'
 static  __init int ath79_setup(void)
                    ^
arch/mips/ath79/setup.c:299:1: error: initializer element is not constant
 arch_initcall(ath79_setup);

It turns out to be a simple error of a missed closing brace.

Fixes: f63ba725caa7 ("MIPS: ath79: Disable platform code for OF boards.")
Cc: Antony Pavlov <antonynpavlov@gmail.com>
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---

Build log of next-20160330 is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/119417999

 arch/mips/ath79/setup.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/ath79/setup.c b/arch/mips/ath79/setup.c
index 897f49a..e0ff6f3 100644
--- a/arch/mips/ath79/setup.c
+++ b/arch/mips/ath79/setup.c
@@ -214,6 +214,7 @@ void __init plat_mem_setup(void)
 						 AR71XX_PLL_SIZE);
 		ath79_detect_sys_type();
 		ath79_ddr_ctrl_init();
+	}
 
 	detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX);
 	/* OF machines should use the reset driver */
-- 
2.1.4

             reply	other threads:[~2016-03-30 15:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30 15:29 Sudip Mukherjee [this message]
2016-03-30 19:13 ` Antony Pavlov
2016-03-30 21:56   ` Ralf Baechle
2016-03-31 14:08     ` Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459351789-24544-1-git-send-email-sudipm.mukherjee@gmail.com \
    --to=sudipm.mukherjee@gmail.com \
    --cc=antonynpavlov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®