From: Antony Pavlov <antonynpavlov@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: ath79: fix build failure
Date: Thu, 31 Mar 2016 17:08:31 +0300 [thread overview]
Message-ID: <20160331170831.d775fe49863273c06177a4be@gmail.com> (raw)
In-Reply-To: <20160330215618.GB5275@linux-mips.org>
On Wed, 30 Mar 2016 23:56:18 +0200
Ralf Baechle <ralf@linux-mips.org> wrote:
> On Wed, Mar 30, 2016 at 10:13:29PM +0300, Antony Pavlov wrote:
>
> > It is very strange because my original patch has this closing brace.
> > Please see my original patch
> > https://www.linux-mips.org/archives/linux-mips/2016-03/msg00267.html
>
> The patch didn't apply cleanly and I botched resolving it, sorry. I folded
> the fix into the patch.
>
> > Also I suppose that we have no need in detect_memory_region() if we use devicetree,
> > e.g.
> >
> > ath79_detect_sys_type();
> > ath79_ddr_ctrl_init();
> > + detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX);
> > + }
> >
> > - detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX);
>
> "suppose" is a bit weak.. Should I move the detect_memory_region call?
I have just examined lastest master from git://git.linux-mips.org/pub/scm/ralf/linux
The problem is a bit more complex. We have to move _machine_restart assignment too.
I'll send fixup in a few seconds.
Also please remove a dot from commit title.
--
Best regards,
Antony Pavlov
prev parent reply other threads:[~2016-03-31 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:29 Sudip Mukherjee
2016-03-30 19:13 ` Antony Pavlov
2016-03-30 21:56 ` Ralf Baechle
2016-03-31 14:08 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331170831.d775fe49863273c06177a4be@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome