[PATCH 13/14] staging: fsl-mc: return -EINVAL for all fsl_mc_portal_allocate() failures

[PATCH 13/14] staging: fsl-mc: return -EINVAL for all fsl_mc_portal_allocate() failures

[Stuart Yoder]

From: Horia Geantă <horia.geanta@freescale.com>

There are some error paths that allow for a NULL new_mc_io and err = 0
return code. Return -EINVAL instead.

Signed-off-by: Horia Geantă <horia.geanta@freescale.com>
Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
---
 drivers/staging/fsl-mc/bus/mc-allocator.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c b/drivers/staging/fsl-mc/bus/mc-allocator.c
index 4676ba1..7ee71e7 100644
--- a/drivers/staging/fsl-mc/bus/mc-allocator.c
+++ b/drivers/staging/fsl-mc/bus/mc-allocator.c
@@ -306,6 +306,7 @@ int __must_check fsl_mc_portal_allocate(struct fsl_mc_device *mc_dev,
 	if (error < 0)
 		return error;
 
+	error = -EINVAL;
 	dpmcp_dev = resource->data;
 	if (WARN_ON(!dpmcp_dev))
 		goto error_cleanup_resource;
-- 
1.7.9.5

[PATCH 13/14] staging: fsl-mc: return -EINVAL for all fsl_mc_portal_allocate() failures

[Stuart Yoder]

From: Horia Geantă <horia.geanta@nxp.com>

There are some error paths that allow for a NULL new_mc_io and err = 0
return code. Return -EINVAL instead.

Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
---
 drivers/staging/fsl-mc/bus/mc-allocator.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c b/drivers/staging/fsl-mc/bus/mc-allocator.c
index 4676ba1..7ee71e7 100644
--- a/drivers/staging/fsl-mc/bus/mc-allocator.c
+++ b/drivers/staging/fsl-mc/bus/mc-allocator.c
@@ -306,6 +306,7 @@ int __must_check fsl_mc_portal_allocate(struct fsl_mc_device *mc_dev,
 	if (error < 0)
 		return error;
 
+	error = -EINVAL;
 	dpmcp_dev = resource->data;
 	if (WARN_ON(!dpmcp_dev))
 		goto error_cleanup_resource;
-- 
1.7.9.5

RE: [PATCH 13/14] staging: fsl-mc: return -EINVAL for all fsl_mc_portal_allocate() failures

[Stuart Yoder]

> -----Original Message-----
> From: Stuart Yoder <stuart.yoder@nxp.com>
> Date: Mon, Apr 11, 2016 at 11:56 AM
> Subject: [PATCH 13/14] staging: fsl-mc: return -EINVAL for all
> fsl_mc_portal_allocate() failures
> To: gregkh@linuxfoundation.org, german.rivera@nxp.com
> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
> agraf@suse.de, arnd@arndb.de, leoyang.li@nxp.com, Horia Geantă
> <horia.geanta@nxp.com>, Stuart Yoder <stuart.yoder@nxp.com>
> 
> 
> From: Horia Geantă <horia.geanta@nxp.com>
> 
> There are some error paths that allow for a NULL new_mc_io and err = 0
> return code. Return -EINVAL instead.
> 
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
> ---
>  drivers/staging/fsl-mc/bus/mc-allocator.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c
> b/drivers/staging/fsl-mc/bus/mc-allocator.c
> index 4676ba1..7ee71e7 100644
> --- a/drivers/staging/fsl-mc/bus/mc-allocator.c
> +++ b/drivers/staging/fsl-mc/bus/mc-allocator.c
> @@ -306,6 +306,7 @@ int __must_check fsl_mc_portal_allocate(struct
> fsl_mc_device *mc_dev,
>         if (error < 0)
>                 return error;
> 
> +       error = -EINVAL;
>         dpmcp_dev = resource->data;
>         if (WARN_ON(!dpmcp_dev))
>                 goto error_cleanup_resource;
> --
> 1.7.9.5

I had smtp mail server weirdness that led me to belive that the freescale.com
email addresses in this patch were causing the patch to not show up on the
mailing list, so I resent [PATCH 13/14] with the email address changed to
nxp.com.  Then both copies of [PATCH 13/14] showed up.  So please ignore
the duplicated email for this patch.  Both copies are identical and either
either freescale.com or nxp.com are ok for the email address.  nxp.com
version would be preferred I guess.

Thanks,
Stuart