From: Ming Lei <ming.lei@canonical.com>
To: Jens Axboe <axboe@fb.com>, linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Ming Lei <ming.lei@canonical.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
drbd-dev@lists.linbit.com (open list:DRBD DRIVER)
Subject: [PATCH v5 7/8] block: drbd: avoid to use BIO_MAX_SIZE
Date: Mon, 18 Apr 2016 05:29:56 +0800 [thread overview]
Message-ID: <1460928615-20894-8-git-send-email-ming.lei@canonical.com> (raw)
In-Reply-To: <1460928615-20894-1-git-send-email-ming.lei@canonical.com>
drbd is the only user of BIO_MAX_SIZE, so use BIO_MAX_PAGES
instead.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
drivers/block/drbd/drbd_int.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
index 7a1cf7e..e6e4b08 100644
--- a/drivers/block/drbd/drbd_int.h
+++ b/drivers/block/drbd/drbd_int.h
@@ -1327,14 +1327,14 @@ struct bm_extent {
#endif
#endif
-/* BIO_MAX_SIZE is 256 * PAGE_SIZE,
+/* Estimate max bio size as 256 * PAGE_SIZE,
* so for typical PAGE_SIZE of 4k, that is (1<<20) Byte.
* Since we may live in a mixed-platform cluster,
* we limit us to a platform agnostic constant here for now.
* A followup commit may allow even bigger BIO sizes,
* once we thought that through. */
#define DRBD_MAX_BIO_SIZE (1U << 20)
-#if DRBD_MAX_BIO_SIZE > BIO_MAX_SIZE
+#if DRBD_MAX_BIO_SIZE > (BIO_MAX_PAGES << PAGE_SHIFT)
#error Architecture not supported: DRBD_MAX_BIO_SIZE > BIO_MAX_SIZE
#endif
#define DRBD_MAX_BIO_SIZE_SAFE (1U << 12) /* Works always = 4k */
--
1.9.1
next prev parent reply other threads:[~2016-04-17 21:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-17 21:29 [PATCH v5 0/8] block: prepare for multipage bvecs Ming Lei
2016-04-17 21:29 ` [PATCH v5 1/8] block: move bvec iterator into include/linux/bvec.h Ming Lei
2016-05-02 14:56 ` Christoph Hellwig
2016-04-17 21:29 ` [PATCH v5 2/8] block: move two bvec structure into bvec.h Ming Lei
2016-05-02 14:57 ` Christoph Hellwig
2016-04-17 21:29 ` [PATCH v5 3/8] block: mark 1st parameter of bvec_iter_advance as const Ming Lei
2016-04-17 21:29 ` [PATCH v5 4/8] iov_iter: use bvec iterator to implement iterate_bvec() Ming Lei
2016-05-02 14:57 ` Christoph Hellwig
2016-04-17 21:29 ` [PATCH v5 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Ming Lei
2016-05-02 14:57 ` Christoph Hellwig
2016-04-17 21:29 ` [PATCH v5 6/8] block: bio: remove BIO_MAX_SECTORS Ming Lei
2016-04-17 21:29 ` Ming Lei [this message]
2016-04-17 21:29 ` [PATCH v5 8/8] block: bio: remove BIO_MAX_SIZE Ming Lei
2016-05-03 1:03 ` [PATCH v5 0/8] block: prepare for multipage bvecs Ming Lei
2016-05-08 9:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460928615-20894-8-git-send-email-ming.lei@canonical.com \
--to=ming.lei@canonical.com \
--cc=axboe@fb.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@infradead.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®