mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tobin C Harding <me@tobin.cc>
To: gregkh@linuxfoundation.org
Cc: arve@android.com, riandrews@android.com,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	Tobin C Harding <me@tobin.cc>
Subject: [PATCH v2 3/4] drivers: staging: remove comparison to NULL
Date: Mon, 18 Apr 2016 10:35:30 +1000	[thread overview]
Message-ID: <1460939731-7746-4-git-send-email-me@tobin.cc> (raw)
In-Reply-To: <1460939731-7746-1-git-send-email-me@tobin.cc>

drivers/staging/android/ion/ion.c checkpatch produces
'Comparison to NULL could be written ...' checks. 

This patch replaces comparison to NULL with !var as suggested by checkpatch.

Signed-off-by: Tobin C Harding <me@tobin.cc>
---
 drivers/staging/android/ion/ion.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 4e02209..234848f 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -209,7 +209,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
 	buffer->size = len;
 
 	table = heap->ops->map_dma(heap, buffer);
-	if (WARN_ONCE(table == NULL,
+	if (WARN_ONCE(!table,
 		      "heap->ops->map_dma should return ERR_PTR on error"))
 		table = ERR_PTR(-EINVAL);
 	if (IS_ERR(table)) {
@@ -522,7 +522,7 @@ struct ion_handle *ion_alloc(struct ion_client *client, size_t len,
 	}
 	up_read(&dev->lock);
 
-	if (buffer == NULL)
+	if (!buffer)
 		return ERR_PTR(-ENODEV);
 
 	if (IS_ERR(buffer))
@@ -612,7 +612,7 @@ static void *ion_buffer_kmap_get(struct ion_buffer *buffer)
 		return buffer->vaddr;
 	}
 	vaddr = buffer->heap->ops->map_kernel(buffer->heap, buffer);
-	if (WARN_ONCE(vaddr == NULL,
+	if (WARN_ONCE(!vaddr,
 		      "heap->ops->map_kernel should return ERR_PTR on error"))
 		return ERR_PTR(-EINVAL);
 	if (IS_ERR(vaddr))
-- 
2.7.4

  parent reply	other threads:[~2016-04-18  0:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18  0:35 [PATCH v2 0/4] drivers: staging: checkpatch fixes Tobin C Harding
2016-04-18  0:35 ` [PATCH v2 1/4] drivers: staging: fix parameter alignment Tobin C Harding
2016-04-30  0:49   ` Greg KH
2016-04-18  0:35 ` [PATCH v2 2/4] drivers: staging: fix line length Tobin C Harding
2016-04-18  0:35 ` Tobin C Harding [this message]
2016-04-18  0:35 ` [PATCH v2 4/4] drivers: staging: remove BUG_ON Tobin C Harding
2016-04-18 21:03   ` Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460939731-7746-4-git-send-email-me@tobin.cc \
    --to=me@tobin.cc \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome