From: Laxman Dewangan <ldewangan@nvidia.com>
To: <lee.jones@linaro.org>
Cc: <linux-kernel@vger.kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
Benoit Cousson <b-cousson@ti.com>, Felipe Balbi <balbi@ti.com>,
"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
Sourav Poddar <sourav.poddar@ti.com>
Subject: [PATCH] mfd: smsc-ece1099: Remove unnecessarily remove callback
Date: Thu, 21 Apr 2016 17:45:39 +0530 [thread overview]
Message-ID: <1461240939-21110-1-git-send-email-ldewangan@nvidia.com> (raw)
SMSC MFD driver does not add any MFD child devices via
mfd_add_devices() and hence it is not required to call
mfd_remove_devices() to remove MFD child devices.
Remove the call of the API mfd_remove_devices() which will
result as remove of .remove callback for driver.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Benoit Cousson <b-cousson@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
This is build and compile tested only.
drivers/mfd/smsc-ece1099.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c
index a4c0df7..7f89e89 100644
--- a/drivers/mfd/smsc-ece1099.c
+++ b/drivers/mfd/smsc-ece1099.c
@@ -80,15 +80,6 @@ err:
return ret;
}
-static int smsc_i2c_remove(struct i2c_client *i2c)
-{
- struct smsc *smsc = i2c_get_clientdata(i2c);
-
- mfd_remove_devices(smsc->dev);
-
- return 0;
-}
-
static const struct i2c_device_id smsc_i2c_id[] = {
{ "smscece1099", 0},
{},
@@ -100,7 +91,6 @@ static struct i2c_driver smsc_i2c_driver = {
.name = "smsc",
},
.probe = smsc_i2c_probe,
- .remove = smsc_i2c_remove,
.id_table = smsc_i2c_id,
};
--
2.1.4
next reply other threads:[~2016-04-21 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 12:15 Laxman Dewangan [this message]
2016-04-25 16:23 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461240939-21110-1-git-send-email-ldewangan@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome