mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PULL] clockevents fixes for 4.6
@ 2016-04-22  7:27 Daniel Lezcano
  2016-04-22  7:29 ` [PATCH] clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test Daniel Lezcano
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Lezcano @ 2016-04-22  7:27 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar; +Cc: linux-kernel, marc_gonzalez

Hi Thomas, Ingo,

Please pull this fix for the tango xtal driver.

 * Fix the boot hang on Sigma Design Tango4 by inverting the error check
   condition at init time (Daniel Lezcano)

The following changes since commit b7c8b4aac6ea6746b1c49fda0a0563a07203dd26:

  clocksource/drivers/pistachio: Correct output format of PTR_ERR() 
(2016-03-23 12:30:40 +0100)

are available in the git repository at:

  http://git.linaro.org/people/daniel.lezcano/linux.git 
clockevents/4.6-fixes

for you to fetch changes up to 16eeed7e5558a3dcf30f75526a896b2632f299f9:

  clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test 
(2016-04-22 09:22:37 +0200)

----------------------------------------------------------------
Daniel Lezcano (1):
      clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test

 drivers/clocksource/tango_xtal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test
  2016-04-22  7:27 [PULL] clockevents fixes for 4.6 Daniel Lezcano
@ 2016-04-22  7:29 ` Daniel Lezcano
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2016-04-22  7:29 UTC (permalink / raw)
  To: tglx; +Cc: mingo, Marc Gonzalez, open list:CLOCKSOURCE, CLOC...

Commit 0881841f7e78 introduced a regression by inverting a test check
after calling clocksource_mmio_init(). That results on the system to
hang at boot time.

Fix it by inverting the test again.

Fixes: 0881841f7e78 ("Replace code by clocksource_mmio_init")
Reported-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/tango_xtal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/tango_xtal.c b/drivers/clocksource/tango_xtal.c
index 2bcecaf..c407c47 100644
--- a/drivers/clocksource/tango_xtal.c
+++ b/drivers/clocksource/tango_xtal.c
@@ -42,7 +42,7 @@ static void __init tango_clocksource_init(struct device_node *np)
 
 	ret = clocksource_mmio_init(xtal_in_cnt, "tango-xtal", xtal_freq, 350,
 				    32, clocksource_mmio_readl_up);
-	if (!ret) {
+	if (ret) {
 		pr_err("%s: registration failed\n", np->full_name);
 		return;
 	}
-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-22  7:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-22  7:27 [PULL] clockevents fixes for 4.6 Daniel Lezcano
2016-04-22  7:29 ` [PATCH] clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®