* [PATCH net-next v2] of: of_mdio: Check if MDIO bus controller is available
@ 2016-04-28 23:24 Florian Fainelli
0 siblings, 0 replies; only message in thread
From: Florian Fainelli @ 2016-04-28 23:24 UTC (permalink / raw)
To: netdev
Cc: davem, andrew, nathan.sullivan, nicolas.ferre, Florian Fainelli,
Rob Herring, Frank Rowand, Grant Likely,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE, open list
Add a check whether the 'struct device_node' pointer passed to
of_mdiobus_register() is an available (aka enabled) node in the Device
Tree.
Rationale for doing this are cases where an Ethernet MAC provides a MDIO
bus controller and node, and an additional Ethernet MAC might be
connecting its PHY/switches to that first MDIO bus controller, while
still embedding one internally which is therefore marked as "disabled".
Instead of sprinkling checks like these in callers of
of_mdiobus_register(), do this in a central location.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:
- utilize -ENODEV instead of -EINVAL
- added Andrew's reviewed-by tag
drivers/of/of_mdio.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index b622b33dbf93..e051e1b57609 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -209,6 +209,10 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
bool scanphys = false;
int addr, rc;
+ /* Do not continue if the node is disabled */
+ if (!of_device_is_available(np))
+ return -ENODEV;
+
/* Mask out all PHYs from auto probing. Instead the PHYs listed in
* the device tree are populated after the bus has been registered */
mdio->phy_mask = ~0;
--
2.1.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-04-28 23:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-28 23:24 [PATCH net-next v2] of: of_mdio: Check if MDIO bus controller is available Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®