From: "jeffrey.lin" <yajohn@gmail.com>
To: dmitry.torokhov@gmail.com, rydberg@euromail.se,
grant.likely@linaro.org, robh+dt@kernel.org, jeesw@melfas.com,
bleung@chromium.org
Cc: jeffrey.lin@rad-ic.com, roger.yang@rad-ic.com, KP.li@rad-ic.com,
albert.shieh@rad-ic.com, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver
Date: Sat, 14 May 2016 01:08:30 +0800 [thread overview]
Message-ID: <1463159310-17630-1-git-send-email-jeffrey.lin@rad-ic.com> (raw)
In-Reply-To: <20160513041852.GA8932@dtor-ws>
Hi Dmitry:
This patch you submitted had some problems. I still debug in progress. Should I comment the issues in this patch or create a new patch if I finish the issues?
>static int raydium_i2c_fastboot(struct i2c_client *client)
> {
>- static const u8 boot_cmd[] = { 0x50, 0x00, 0x06, 0x20 };
>- u8 buf[HEADER_SIZE];
>+ u8 buf[4]; // XXX FIXME why size 4 and not 1?
Correct.Raydium direct access mode is word alignment, so that 4 bytes reading is correct but only lower bytes show the message I need.
>static int raydium_i2c_check_fw_status(struct raydium_data *ts)
>{
> struct i2c_client *client = ts->client;
>- static const u8 bl_area[] = {0x62, 0x6f, 0x6f, 0x74};
>- static const u8 main_area[] = {0x66, 0x69, 0x72, 0x6d};
>- u8 buf[HEADER_SIZE];
>+ static const u8 bl_area[] = { 0x62, 0x6f, 0x6f, 0x74 };
>+ static const u8 main_area[] = { 0x66, 0x69, 0x72, 0x6d };
>+ u8 buf[4];
> int error;
>
>- error = raydium_i2c_read(client, CMD_BOOT_READ, HEADER_SIZE,
>- (void *)buf);
>+ error = raydium_i2c_read(client, RM_CMD_BOOT_READ, buf, sizeof(buf));
> if (!error) {
>+ // XXX FIXME: why do we compare only 1st bytes? Do we even
>+ // need 4-byte constants?
One bytes comparison is fine. I'll change as below:
static int raydium_i2c_check_fw_status(struct raydium_data *ts)
{
struct i2c_client *client = ts->client;
static const u8 bl_ack = 0x62;
static const u8 main_ack = 0x66;
u8 buf[4];
int error;
error = raydium_i2c_read(client, RM_CMD_BOOT_READ, buf, sizeof(buf));
if (!error) {
// XXX FIXME: why do we compare only 1st bytes? Do we even
// need 4-byte constants?
if (buf[0] == bl_ack)
ts->boot_mode = RAYDIUM_TS_BLDR;
else if (buf[0] == main_ack)
ts->boot_mode = RAYDIUM_TS_MAIN;
return 0;
>+ while (len) {
>+ xfer_len = min_t(size_t, len, RM_BL_WRT_PKG_SIZE);
>
>- memcpy(&buf[DATA_STR], page + DATA_STR +
>- u8_idx*RAYDIUM_TRANS_BUFSIZE,
>- RAYDIUM_TRANS_BUFSIZE);
>+ buf[BL_HEADER] = 0x0b;
>+ // XXX FIXME: is this correct? Do we really want all pages
>+ // after 1st to have 0xff? Should it be a counter?
>+ // Why do we need both pages and packages within pages?
>+ buf[BL_PAGE_STR] = page_idx ? 0 : 0xff;
This is correct. Touch MCU need this index as start page.
>+ buf[BL_PKG_IDX] = pkg_idx;
This should be:
buf[BL_PKG_IDX] = pkg_idx++;
>+ memcpy(&buf[BL_DATA_STR], data, xfer_len);
next prev parent reply other threads:[~2016-05-13 17:08 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 9:45 jeffrey.lin
2016-05-04 22:58 ` Dmitry Torokhov
2016-05-06 8:24 ` jeffrey.lin
2016-05-11 16:04 ` jeffrey.lin
2016-05-13 4:18 ` Dmitry Torokhov
2016-05-13 17:08 ` jeffrey.lin [this message]
2016-05-16 15:46 ` jeffrey.lin
2016-05-16 16:41 ` Dmitry Torokhov
2016-05-16 16:43 ` Dmitry Torokhov
2016-05-16 15:57 ` jeffrey.lin
2016-05-17 16:07 ` jeffrey.lin
2016-05-21 18:18 ` Dmitry Torokhov
2016-05-22 9:32 ` jeffrey.lin
2016-05-22 22:37 ` Dmitry Torokhov
2016-05-22 9:35 ` jeffrey.lin
2016-05-23 14:43 ` jeffrey.lin
2016-05-23 16:27 ` Dmitry Torokhov
2016-05-24 9:31 ` jeffrey.lin
2016-05-27 16:34 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2016-05-24 9:05 jeffrey.lin
2016-05-17 15:34 jeffrey.lin
2016-05-11 13:51 jeffrey.lin
2016-04-22 10:01 dan.huang
2016-04-22 22:50 ` Dmitry Torokhov
2016-03-25 5:21 jeffrey.lin
2016-04-11 8:24 ` Dmitry Torokhov
2016-04-11 9:57 ` Jeffrey Lin (林義章)
2016-04-14 9:28 ` Jeffrey Lin (林義章)
2016-03-22 6:23 jeffrey.lin
2016-03-15 8:44 jeffrey.lin
2016-03-18 21:04 ` Rob Herring
2016-03-03 6:42 jeffrey.lin
2016-03-10 18:47 ` Dmitry Torokhov
2016-03-11 2:10 ` Jeffrey Lin (林義章)
2016-03-03 2:29 jeffrey.lin
2016-03-03 2:44 ` Joe Perches
2016-03-03 3:14 ` Jeffrey Lin (林義章)
2016-03-03 3:55 ` Joe Perches
2016-02-23 8:11 jeffrey.lin
2016-01-21 4:02 Jeffrey Lin
2016-01-21 9:37 ` Dmitry Torokhov
2016-01-15 3:30 Jeffrey Lin
2016-01-13 7:49 Jeffrey Lin
2016-01-13 8:31 ` Dmitry Torokhov
2016-01-13 19:14 ` Dmitry Torokhov
2016-01-13 6:23 Jeffrey Lin
2016-01-13 6:44 ` Dmitry Torokhov
2016-01-08 15:17 Jeffrey Lin
2016-01-09 19:20 ` Dmitry Torokhov
2015-01-06 9:25 jeffrey.lin
2015-01-06 19:43 ` Jeremiah Mahler
2015-01-07 0:40 ` Dmitry Torokhov
2014-12-08 3:42 jeffrey.lin
2014-12-05 8:15 jeffrey.lin
2014-12-05 15:04 ` Dmitry Torokhov
2014-11-14 7:19 jeffrey.lin
2014-11-14 17:43 ` Benson Leung
2014-11-14 18:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463159310-17630-1-git-send-email-jeffrey.lin@rad-ic.com \
--to=yajohn@gmail.com \
--cc=KP.li@rad-ic.com \
--cc=albert.shieh@rad-ic.com \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=jeesw@melfas.com \
--cc=jeffrey.lin@rad-ic.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=roger.yang@rad-ic.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®