From: "jeffrey.lin" <yajohn@gmail.com>
To: dmitry.torokhov@gmail.com, rydberg@euromail.se,
grant.likely@linaro.org, robh+dt@kernel.org, jeesw@melfas.com,
bleung@chromium.org
Cc: jeffrey.lin@rad-ic.com, roger.yang@rad-ic.com, KP.li@rad-ic.com,
albert.shieh@rad-ic.com, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver
Date: Mon, 16 May 2016 23:57:28 +0800 [thread overview]
Message-ID: <1463414248-422-1-git-send-email-jeffrey.lin@rad-ic.com> (raw)
In-Reply-To: <20160513041852.GA8932@dtor-ws>
>static int raydium_i2c_do_update_firmware(struct raydium_data *ts,
> const struct firmware *fw)
>{
> struct i2c_client *client = ts->client;
> const void *data;
> size_t data_len;
> size_t len;
> int page_nr;
> int i;
> int error;
> u16 fw_checksum;
>
> if (fw->size == 0) {
additional protect.
if (fw->size == 0 || fw->size > RM_MAX_FW_SIZE) {
> dev_err(&client->dev, "Invalid firmware length\n");
> return -EINVAL;
> }
>
> error = raydium_i2c_check_fw_status(ts);
> if (error) {
> dev_err(&client->dev, "Unable to access IC %d\n", error);
> return error;
> }
>
> if (ts->boot_mode == RAYDIUM_TS_MAIN) {
> for (i = 0; i < RM_MAX_RETRIES; i++) {
> error = raydium_i2c_enter_bl(client);
> if (!error) {
> error = raydium_i2c_check_fw_status(ts);
> if (error) {
> dev_err(&client->dev,
> "unable to access IC: %d\n",
> error);
> return error;
> }
>
> if (ts->boot_mode == RAYDIUM_TS_BLDR)
> break;
> }
> }
>
> if (ts->boot_mode == RAYDIUM_TS_MAIN) {
> dev_err(&client->dev,
> "failied to jump to boot loader: %d\n",
> error);
> return -EIO;
> }
> }
>
> error = raydium_i2c_disable_watch_dog(client);
> if (error)
> return error;
>
> error = raydium_i2c_check_path(client);
> if (error)
> return error;
>
> error = raydium_i2c_boot_trigger(client);
> if (error) {
> dev_err(&client->dev, "send boot trigger fail: %d\n", error);
> return error;
> }
additonal delay for safe
msleep(RM_BOOT_DELAY_MS);
>
> data = fw->data;
> data_len = fw->size;
> page_nr = 0;
>
> while (data_len) {
> len = min_t(size_t, data_len, RM_FW_PAGE_SIZE);
>
> error = raydium_i2c_fw_write_page(client, page_nr++, data, len);
> if (error)
> return error;
>
> // XXX FIXME: we already sleep in raydium_i2c_fw_write_page(),
> // do we really need to sleep here as well?
/*FIXME, remove delay in raydium_i2c_fw_write_page()*/
> msleep(20);
>
> data += len;
> data_len -= len;
> }
next prev parent reply other threads:[~2016-05-16 15:57 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 9:45 jeffrey.lin
2016-05-04 22:58 ` Dmitry Torokhov
2016-05-06 8:24 ` jeffrey.lin
2016-05-11 16:04 ` jeffrey.lin
2016-05-13 4:18 ` Dmitry Torokhov
2016-05-13 17:08 ` jeffrey.lin
2016-05-16 15:46 ` jeffrey.lin
2016-05-16 16:41 ` Dmitry Torokhov
2016-05-16 16:43 ` Dmitry Torokhov
2016-05-16 15:57 ` jeffrey.lin [this message]
2016-05-17 16:07 ` jeffrey.lin
2016-05-21 18:18 ` Dmitry Torokhov
2016-05-22 9:32 ` jeffrey.lin
2016-05-22 22:37 ` Dmitry Torokhov
2016-05-22 9:35 ` jeffrey.lin
2016-05-23 14:43 ` jeffrey.lin
2016-05-23 16:27 ` Dmitry Torokhov
2016-05-24 9:31 ` jeffrey.lin
2016-05-27 16:34 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2016-05-24 9:05 jeffrey.lin
2016-05-17 15:34 jeffrey.lin
2016-05-11 13:51 jeffrey.lin
2016-04-22 10:01 dan.huang
2016-04-22 22:50 ` Dmitry Torokhov
2016-03-25 5:21 jeffrey.lin
2016-04-11 8:24 ` Dmitry Torokhov
2016-04-11 9:57 ` Jeffrey Lin (林義章)
2016-04-14 9:28 ` Jeffrey Lin (林義章)
2016-03-22 6:23 jeffrey.lin
2016-03-15 8:44 jeffrey.lin
2016-03-18 21:04 ` Rob Herring
2016-03-03 6:42 jeffrey.lin
2016-03-10 18:47 ` Dmitry Torokhov
2016-03-11 2:10 ` Jeffrey Lin (林義章)
2016-03-03 2:29 jeffrey.lin
2016-03-03 2:44 ` Joe Perches
2016-03-03 3:14 ` Jeffrey Lin (林義章)
2016-03-03 3:55 ` Joe Perches
2016-02-23 8:11 jeffrey.lin
2016-01-21 4:02 Jeffrey Lin
2016-01-21 9:37 ` Dmitry Torokhov
2016-01-15 3:30 Jeffrey Lin
2016-01-13 7:49 Jeffrey Lin
2016-01-13 8:31 ` Dmitry Torokhov
2016-01-13 19:14 ` Dmitry Torokhov
2016-01-13 6:23 Jeffrey Lin
2016-01-13 6:44 ` Dmitry Torokhov
2016-01-08 15:17 Jeffrey Lin
2016-01-09 19:20 ` Dmitry Torokhov
2015-01-06 9:25 jeffrey.lin
2015-01-06 19:43 ` Jeremiah Mahler
2015-01-07 0:40 ` Dmitry Torokhov
2014-12-08 3:42 jeffrey.lin
2014-12-05 8:15 jeffrey.lin
2014-12-05 15:04 ` Dmitry Torokhov
2014-11-14 7:19 jeffrey.lin
2014-11-14 17:43 ` Benson Leung
2014-11-14 18:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463414248-422-1-git-send-email-jeffrey.lin@rad-ic.com \
--to=yajohn@gmail.com \
--cc=KP.li@rad-ic.com \
--cc=albert.shieh@rad-ic.com \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=jeesw@melfas.com \
--cc=jeffrey.lin@rad-ic.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=roger.yang@rad-ic.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®