From: Heloise <os@iscas.ac.cn>
To: akpm@linux-foundation.org, hannes@cmpxchg.org, firogm@gmail.com,
vdavydov@virtuozzo.com, viro@zeniv.linux.org.uk
Cc: linux-kernel@vger.kernel.org, os@iscas.ac.cn
Subject: [PATCH] fs:efs:fix return value
Date: Mon, 16 May 2016 23:02:23 -0700 [thread overview]
Message-ID: <1463464943-4142-1-git-send-email-os@iscas.ac.cn> (raw)
When the function sb_bread() fails, the return value should
be -EIO, fix it.
Signed-off-by: Heloise <os@iscas.ac.cn>
---
fs/efs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/efs/super.c b/fs/efs/super.c
index cb68dac..368f7dd 100644
--- a/fs/efs/super.c
+++ b/fs/efs/super.c
@@ -275,7 +275,7 @@ static int efs_fill_super(struct super_block *s, void *d, int silent)
if (!bh) {
pr_err("cannot read volume header\n");
- return -EINVAL;
+ return -EIO;
}
/*
@@ -293,7 +293,7 @@ static int efs_fill_super(struct super_block *s, void *d, int silent)
bh = sb_bread(s, sb->fs_start + EFS_SUPER);
if (!bh) {
pr_err("cannot read superblock\n");
- return -EINVAL;
+ return -EIO;
}
if (efs_validate_super(sb, (struct efs_super *) bh->b_data)) {
--
2.1.0
reply other threads:[~2016-05-17 6:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463464943-4142-1-git-send-email-os@iscas.ac.cn \
--to=os@iscas.ac.cn \
--cc=akpm@linux-foundation.org \
--cc=firogm@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vdavydov@virtuozzo.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®