From: Laura Abbott <labbott@redhat.com>
To: Jan Kara <jack@suse.com>
Cc: Laura Abbott <labbott@fedoraproject.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] udf: Check for IS_ERR in udf_get_pblock_meta25
Date: Wed, 18 May 2016 10:35:31 -0700 [thread overview]
Message-ID: <1463592931-7157-1-git-send-email-labbott@fedoraproject.org> (raw)
udf_find_metadata_inode_efe returns an error pointer, not just
NULL. Check the return with IS_ERR appropriately.
Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
---
Came out of https://bugzilla.redhat.com/show_bug.cgi?id=1301295, I never
heard back from the reporter so I've had this sitting around for a bit and
haven't been able to confirm it fixes the crash. The logic makes sense
for the crash though.
---
fs/udf/partition.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/udf/partition.c b/fs/udf/partition.c
index 5f861ed2..a8ee7fc 100644
--- a/fs/udf/partition.c
+++ b/fs/udf/partition.c
@@ -329,7 +329,7 @@ uint32_t udf_get_pblock_meta25(struct super_block *sb, uint32_t block,
}
inode = mdata->s_mirror_fe;
- if (!inode)
+ if (IS_ERR(inode))
return 0xFFFFFFFF;
retblk = udf_try_read_meta(inode, block, partition, offset);
}
--
2.5.5
next reply other threads:[~2016-05-18 17:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 17:35 Laura Abbott [this message]
2016-05-19 11:47 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463592931-7157-1-git-send-email-labbott@fedoraproject.org \
--to=labbott@redhat.com \
--cc=jack@suse.com \
--cc=labbott@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®