From: "Pali Rohár" <pali.rohar@gmail.com>
To: "Matthew Garrett" <mjg59@srcf.ucam.org>,
"Darren Hart" <dvhart@infradead.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
"Michał Kępień" <kernel@kempniu.pl>,
"Mario Limonciello" <mario_limonciello@dell.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Alex Hung" <alex.hung@canonical.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>
Subject: [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments
Date: Sun, 22 May 2016 13:36:21 +0200 [thread overview]
Message-ID: <1463916983-12562-3-git-send-email-pali.rohar@gmail.com> (raw)
In-Reply-To: <1463916983-12562-1-git-send-email-pali.rohar@gmail.com>
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
drivers/platform/x86/dell-wmi.c | 31 ++++++++++++++++++-------------
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 4d23c91..363d927 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -86,31 +86,32 @@ static const struct dmi_system_id dell_wmi_smbios_list[] __initconst = {
*/
static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
- { KE_IGNORE, 0x003a, { KEY_CAPSLOCK } },
- { KE_KEY, 0xe009, { KEY_EJECTCD } },
+ { KE_IGNORE, 0x003a, { KEY_CAPSLOCK } },
- /* These also contain the brightness level at offset 6 */
- { KE_KEY, 0xe006, { KEY_BRIGHTNESSUP } },
- { KE_KEY, 0xe005, { KEY_BRIGHTNESSDOWN } },
+ /* These also contain the brightness level after key code */
+ { KE_KEY, 0xe006, { KEY_BRIGHTNESSUP } },
+ { KE_KEY, 0xe005, { KEY_BRIGHTNESSDOWN } },
/* Battery health status button */
- { KE_KEY, 0xe007, { KEY_BATTERY } },
+ { KE_KEY, 0xe007, { KEY_BATTERY } },
- /* Radio devices state change */
+ /* Radio devices state change, also contains additional information */
{ KE_IGNORE, 0xe008, { KEY_RFKILL } },
- /* The next device is at offset 6, the active devices are at
- offset 8 and the attached devices at offset 10 */
- { KE_KEY, 0xe00b, { KEY_SWITCHVIDEOMODE } },
+ { KE_KEY, 0xe009, { KEY_EJECTCD } },
+ /* After key code is: next device, active devices, attached devices */
+ { KE_KEY, 0xe00b, { KEY_SWITCHVIDEOMODE } },
+
+ /* Also contains keyboard illumination level after key code */
{ KE_IGNORE, 0xe00c, { KEY_KBDILLUMTOGGLE } },
/* BIOS error detected */
{ KE_IGNORE, 0xe00d, { KEY_RESERVED } },
/* Wifi Catcher */
- { KE_KEY, 0xe011, {KEY_PROG2 } },
+ { KE_KEY, 0xe011, { KEY_PROG2 } },
/* Ambient light sensor toggle */
{ KE_IGNORE, 0xe013, { KEY_RESERVED } },
@@ -118,12 +119,14 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
{ KE_IGNORE, 0xe020, { KEY_MUTE } },
/* Dell Instant Launch key */
- { KE_KEY, 0xe025, { KEY_PROG4 } },
- { KE_KEY, 0xe029, { KEY_PROG4 } },
+ { KE_KEY, 0xe025, { KEY_PROG4 } },
/* Audio panel key */
{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
+ /* Dell Instant Launch key */
+ { KE_KEY, 0xe029, { KEY_PROG4 } },
+
{ KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } },
{ KE_IGNORE, 0xe030, { KEY_VOLUMEUP } },
{ KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } },
@@ -146,7 +149,9 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
{ KE_IGNORE, 0xe0f7, { KEY_MUTE } },
{ KE_IGNORE, 0xe0f8, { KEY_VOLUMEDOWN } },
{ KE_IGNORE, 0xe0f9, { KEY_VOLUMEUP } },
+
{ KE_END, 0 }
+
};
static bool dell_new_hk_type;
--
1.7.9.5
next prev parent reply other threads:[~2016-05-22 11:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-22 11:36 [PATCH 0/4] dell-wmi: Changes in WMI event code handling Pali Rohár
2016-05-22 11:36 ` [PATCH 1/4] dell-wmi: Ignore WMI event code 0xe045 Pali Rohár
2016-05-22 11:36 ` Pali Rohár [this message]
2016-06-02 10:41 ` [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments Michał Kępień
2016-06-07 22:03 ` Pali Rohár
2016-06-08 19:48 ` Darren Hart
2016-06-08 19:57 ` Pali Rohár
2016-06-08 20:15 ` Darren Hart
2016-06-08 20:27 ` Pali Rohár
2016-06-08 20:43 ` Darren Hart
2016-06-08 20:49 ` Pali Rohár
2016-05-22 11:36 ` [PATCH 3/4] dell-wmi: Add information about other WMI event codes Pali Rohár
2016-05-26 22:04 ` Gabriele Mazzotta
2016-06-07 23:00 ` Pali Rohár
2016-06-08 6:02 ` Mario_Limonciello
2016-06-08 10:44 ` Gabriele Mazzotta
2016-06-15 19:51 ` Pali Rohár
2016-06-21 19:51 ` Mario_Limonciello
2016-06-22 7:56 ` Pali Rohár
2016-06-22 13:40 ` Mario_Limonciello
2016-06-22 14:12 ` Pali Rohár
2016-06-22 14:21 ` Mario_Limonciello
2016-06-22 14:24 ` Pali Rohár
2016-06-22 14:28 ` Mario_Limonciello
2016-06-22 14:31 ` Pali Rohár
2016-06-22 14:34 ` Mario_Limonciello
2016-06-22 14:38 ` Pali Rohár
2016-06-22 14:39 ` Gabriele Mazzotta
2016-06-22 14:46 ` Mario_Limonciello
2016-06-02 10:41 ` Michał Kępień
2016-06-07 22:06 ` Pali Rohár
2016-05-22 11:36 ` [PATCH 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events Pali Rohár
2016-05-23 17:07 ` Andy Lutomirski
2016-06-02 10:42 ` Michał Kępień
2016-06-07 22:30 ` Pali Rohár
2016-06-02 10:52 ` [PATCH 0/4] dell-wmi: Changes in WMI event code handling Michał Kępień
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463916983-12562-3-git-send-email-pali.rohar@gmail.com \
--to=pali.rohar@gmail.com \
--cc=alex.hung@canonical.com \
--cc=dvhart@infradead.org \
--cc=gabriele.mzt@gmail.com \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mario_limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome