From: Darren Hart <dvhart@infradead.org>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: "Michał Kępień" <kernel@kempniu.pl>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
"Mario Limonciello" <mario_limonciello@dell.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Alex Hung" <alex.hung@canonical.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments
Date: Wed, 8 Jun 2016 12:48:24 -0700 [thread overview]
Message-ID: <20160608194824.GC28348@f23x64.localdomain> (raw)
In-Reply-To: <20160607220324.GN29844@pali>
On Wed, Jun 08, 2016 at 12:03:24AM +0200, Pali Rohár wrote:
> On Thursday 02 June 2016 12:41:42 Michał Kępień wrote:
> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> >
> > My guess is that Darren won't let you off without at least a short
> > commit message.
>
> I have no idea what else to write. I think that description is enough.
There is always something. For example, why? See Documentation/SubmittingPatches
section "14) The canonical patch format" for an explanation.
"Traceability" of changes is important. If it's worth preparing the patch, it's
worth documenting why.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-06-08 19:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-22 11:36 [PATCH 0/4] dell-wmi: Changes in WMI event code handling Pali Rohár
2016-05-22 11:36 ` [PATCH 1/4] dell-wmi: Ignore WMI event code 0xe045 Pali Rohár
2016-05-22 11:36 ` [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments Pali Rohár
2016-06-02 10:41 ` Michał Kępień
2016-06-07 22:03 ` Pali Rohár
2016-06-08 19:48 ` Darren Hart [this message]
2016-06-08 19:57 ` Pali Rohár
2016-06-08 20:15 ` Darren Hart
2016-06-08 20:27 ` Pali Rohár
2016-06-08 20:43 ` Darren Hart
2016-06-08 20:49 ` Pali Rohár
2016-05-22 11:36 ` [PATCH 3/4] dell-wmi: Add information about other WMI event codes Pali Rohár
2016-05-26 22:04 ` Gabriele Mazzotta
2016-06-07 23:00 ` Pali Rohár
2016-06-08 6:02 ` Mario_Limonciello
2016-06-08 10:44 ` Gabriele Mazzotta
2016-06-15 19:51 ` Pali Rohár
2016-06-21 19:51 ` Mario_Limonciello
2016-06-22 7:56 ` Pali Rohár
2016-06-22 13:40 ` Mario_Limonciello
2016-06-22 14:12 ` Pali Rohár
2016-06-22 14:21 ` Mario_Limonciello
2016-06-22 14:24 ` Pali Rohár
2016-06-22 14:28 ` Mario_Limonciello
2016-06-22 14:31 ` Pali Rohár
2016-06-22 14:34 ` Mario_Limonciello
2016-06-22 14:38 ` Pali Rohár
2016-06-22 14:39 ` Gabriele Mazzotta
2016-06-22 14:46 ` Mario_Limonciello
2016-06-02 10:41 ` Michał Kępień
2016-06-07 22:06 ` Pali Rohár
2016-05-22 11:36 ` [PATCH 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events Pali Rohár
2016-05-23 17:07 ` Andy Lutomirski
2016-06-02 10:42 ` Michał Kępień
2016-06-07 22:30 ` Pali Rohár
2016-06-02 10:52 ` [PATCH 0/4] dell-wmi: Changes in WMI event code handling Michał Kępień
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160608194824.GC28348@f23x64.localdomain \
--to=dvhart@infradead.org \
--cc=alex.hung@canonical.com \
--cc=gabriele.mzt@gmail.com \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mario_limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®