From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Taeung Song <treeze.taeung@gmail.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: [PATCH v3 4/7] perf config: Initialize ui_browser__colorsets with default config items
Date: Tue, 24 May 2016 15:50:23 +0900 [thread overview]
Message-ID: <1464072626-21161-5-git-send-email-treeze.taeung@gmail.com> (raw)
In-Reply-To: <1464072626-21161-1-git-send-email-treeze.taeung@gmail.com>
Set default config values for 'colors' section with 'colors_config_items[]'
instead of actual const char * type values.
(e.g. using colors_config_item[CONFIG_COLORS_TOP].value
instead of "red, default" string value for 'colors.top')
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
tools/perf/ui/browser.c | 53 +++++++++++++++++++++++++++++--------------------
tools/perf/ui/browser.h | 2 ++
2 files changed, 34 insertions(+), 21 deletions(-)
diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index 8e06b2e..00a91e0 100644
--- a/tools/perf/ui/browser.c
+++ b/tools/perf/ui/browser.c
@@ -507,39 +507,32 @@ static struct ui_browser_colorset {
int colorset;
} ui_browser__colorsets[] = {
{
- .colorset = HE_COLORSET_TOP,
- .name = "top",
- .fb_ground = "red, default",
+ .colorset = HE_COLORSET_TOP,
+ .name = "top",
},
{
- .colorset = HE_COLORSET_MEDIUM,
- .name = "medium",
- .fb_ground = "green, default",
+ .colorset = HE_COLORSET_MEDIUM,
+ .name = "medium",
},
{
- .colorset = HE_COLORSET_NORMAL,
- .name = "normal",
- .fb_ground = "default, default",
+ .colorset = HE_COLORSET_NORMAL,
+ .name = "normal",
},
{
- .colorset = HE_COLORSET_SELECTED,
- .name = "selected",
- .fb_ground = "black, yellow",
+ .colorset = HE_COLORSET_SELECTED,
+ .name = "selected",
},
{
- .colorset = HE_COLORSET_JUMP_ARROWS,
- .name = "jump_arrows",
- .fb_ground = "blue, default",
+ .colorset = HE_COLORSET_JUMP_ARROWS,
+ .name = "jump_arrows",
},
{
- .colorset = HE_COLORSET_ADDR,
- .name = "addr",
- .fb_ground = "magenta, default",
+ .colorset = HE_COLORSET_ADDR,
+ .name = "addr",
},
{
- .colorset = HE_COLORSET_ROOT,
- .name = "root",
- .fb_ground = "white, blue",
+ .colorset = HE_COLORSET_ROOT,
+ .name = "root",
},
{
.name = NULL,
@@ -724,10 +717,28 @@ void __ui_browser__line_arrow(struct ui_browser *browser, unsigned int column,
__ui_browser__line_arrow_down(browser, column, start, end);
}
+void default_colors_config_init(void)
+{
+ int i, j;
+
+ for (i = 0; ui_browser__colorsets[i].name != NULL; ++i) {
+ const char *name = ui_browser__colorsets[i].name;
+
+ for (j = 0; colors_config_items[j].name != NULL; j++) {
+ if (!strcmp(name, colors_config_items[j].name)) {
+ ui_browser__colorsets[i].fb_ground =
+ colors_config_items[j].value.s;
+ break;
+ }
+ }
+ }
+}
+
void ui_browser__init(void)
{
int i = 0;
+ default_colors_config_init();
perf_config(ui_browser__color_config, NULL);
while (ui_browser__colorsets[i].name) {
diff --git a/tools/perf/ui/browser.h b/tools/perf/ui/browser.h
index be3b70e..46921e5 100644
--- a/tools/perf/ui/browser.h
+++ b/tools/perf/ui/browser.h
@@ -75,4 +75,6 @@ unsigned int ui_browser__list_head_refresh(struct ui_browser *browser);
void ui_browser__init(void);
void annotate_browser__init(void);
+
+void default_colors_config_init(void);
#endif /* _PERF_UI_BROWSER_H_ */
--
2.5.0
next prev parent reply other threads:[~2016-05-24 6:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 6:50 [PATCH v3 0/7] perf config: Introduce default config key-value pairs arrays Taeung Song
2016-05-24 6:50 ` [PATCH v3 1/7] perf config: Introduce default_config_item for default config key-value pairs Taeung Song
2016-05-24 6:50 ` [PATCH v3 2/7] perf config: Add 'colors' section default configs arrrays Taeung Song
2016-05-24 6:50 ` [PATCH v3 3/7] perf config: Use combined {fore,back}ground colors value instead of each two color Taeung Song
2016-05-24 6:50 ` Taeung Song [this message]
2016-05-24 6:50 ` [PATCH v3 5/7] perf config: Introduce perf_default_config_init() Taeung Song
2016-05-24 6:50 ` [PATCH v3 6/7] perf config: Add 'annotate' section default configs arrrays Taeung Song
2016-05-24 6:50 ` [PATCH v3 7/7] perf config: Initialize annotate_browser__opts with default config items Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464072626-21161-5-git-send-email-treeze.taeung@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®