From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Taeung Song <treeze.taeung@gmail.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: [PATCH v3 7/7] perf config: Initialize annotate_browser__opts with default config items
Date: Tue, 24 May 2016 15:50:26 +0900 [thread overview]
Message-ID: <1464072626-21161-8-git-send-email-treeze.taeung@gmail.com> (raw)
In-Reply-To: <1464072626-21161-1-git-send-email-treeze.taeung@gmail.com>
Set default config values for 'annotate' section with 'annotate_config_items[]'
instead of actual bool type values.
(e.g. using annotate_config_items[CONFIG_ANNOTATE_USE_OFFSET].value
instead of 'true' bool type value for 'annotate.use_offset'.)
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
tools/perf/perf.c | 1 +
tools/perf/ui/browser.h | 1 +
tools/perf/ui/browsers/annotate.c | 15 +++++++++++----
tools/perf/util/config.h | 6 ++++++
4 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/tools/perf/perf.c b/tools/perf/perf.c
index e140b551..d5541fa 100644
--- a/tools/perf/perf.c
+++ b/tools/perf/perf.c
@@ -80,6 +80,7 @@ struct pager_config {
static void perf_default_config_init(void)
{
default_colors_config_init();
+ default_annotate_config_init();
}
static int pager_command_config(const char *var, const char *value, void *data)
diff --git a/tools/perf/ui/browser.h b/tools/perf/ui/browser.h
index 46921e5..b7dc178 100644
--- a/tools/perf/ui/browser.h
+++ b/tools/perf/ui/browser.h
@@ -77,4 +77,5 @@ void ui_browser__init(void);
void annotate_browser__init(void);
void default_colors_config_init(void);
+void default_annotate_config_init(void);
#endif /* _PERF_UI_BROWSER_H_ */
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index 4fc208e..35c2547 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -37,10 +37,7 @@ static struct annotate_browser_opt {
show_linenr,
show_nr_jumps,
show_total_period;
-} annotate_browser__opts = {
- .use_offset = true,
- .jump_arrows = true,
-};
+} annotate_browser__opts;
struct annotate_browser {
struct ui_browser b;
@@ -1158,6 +1155,16 @@ static int annotate__config(const char *var, const char *value,
return 0;
}
+void default_annotate_config_init(void)
+{
+ annotate_browser__opts.hide_src_code = CONF_ANNOTATE_DEFAULT_VAL(HIDE_SRC_CODE, b);
+ annotate_browser__opts.use_offset = CONF_ANNOTATE_DEFAULT_VAL(USE_OFFSET, b);
+ annotate_browser__opts.jump_arrows = CONF_ANNOTATE_DEFAULT_VAL(JUMP_ARROWS, b);
+ annotate_browser__opts.show_linenr = CONF_ANNOTATE_DEFAULT_VAL(SHOW_LINENR, b);
+ annotate_browser__opts.show_nr_jumps = CONF_ANNOTATE_DEFAULT_VAL(SHOW_NR_JUMPS, b);
+ annotate_browser__opts.show_total_period = CONF_ANNOTATE_DEFAULT_VAL(SHOW_TOTAL_PERIOD, b);
+}
+
void annotate_browser__init(void)
{
perf_config(annotate__config, NULL);
diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h
index 696e5bc..7b70971 100644
--- a/tools/perf/util/config.h
+++ b/tools/perf/util/config.h
@@ -88,6 +88,12 @@ enum annotate_config_items_idx {
#define CONF_END() \
{ .name = NULL }
+#define CONF_DEFAULT_VAL(section, name, field) \
+ section##_config_items[CONFIG_##name].value.field
+
+#define CONF_ANNOTATE_DEFAULT_VAL(name, field) \
+ CONF_DEFAULT_VAL(annotate, ANNOTATE_##name, field)
+
extern const struct default_config_item colors_config_items[];
extern const struct default_config_item annotate_config_items[];
--
2.5.0
prev parent reply other threads:[~2016-05-24 6:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 6:50 [PATCH v3 0/7] perf config: Introduce default config key-value pairs arrays Taeung Song
2016-05-24 6:50 ` [PATCH v3 1/7] perf config: Introduce default_config_item for default config key-value pairs Taeung Song
2016-05-24 6:50 ` [PATCH v3 2/7] perf config: Add 'colors' section default configs arrrays Taeung Song
2016-05-24 6:50 ` [PATCH v3 3/7] perf config: Use combined {fore,back}ground colors value instead of each two color Taeung Song
2016-05-24 6:50 ` [PATCH v3 4/7] perf config: Initialize ui_browser__colorsets with default config items Taeung Song
2016-05-24 6:50 ` [PATCH v3 5/7] perf config: Introduce perf_default_config_init() Taeung Song
2016-05-24 6:50 ` [PATCH v3 6/7] perf config: Add 'annotate' section default configs arrrays Taeung Song
2016-05-24 6:50 ` Taeung Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464072626-21161-8-git-send-email-treeze.taeung@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®