mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rhyland Klein <rklein@nvidia.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Alexandre Courbot <gnurou@gmail.com>, <linux-clk@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Rhyland Klein <rklein@nvidia.com>
Subject: [PATCH 11/11] clk: tegra: WARN if clk in the init_table has enable
Date: Wed, 25 May 2016 18:24:31 -0400	[thread overview]
Message-ID: <1464215071-28696-12-git-send-email-rklein@nvidia.com> (raw)
In-Reply-To: <1464215071-28696-1-git-send-email-rklein@nvidia.com>

Enabling clocks through the init_table mechanism is deprecated. Clocks
that need to be enabled early and stay on should be marked as CRITICAL.

Signed-off-by: Rhyland Klein <rklein@nvidia.com>
---
 drivers/clk/tegra/clk.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c
index b2cdd9a235f4..898fe922c742 100644
--- a/drivers/clk/tegra/clk.c
+++ b/drivers/clk/tegra/clk.c
@@ -262,6 +262,11 @@ void __init tegra_init_from_table(struct tegra_clk_init_table *tbl,
 				WARN_ON(1);
 			}
 
+		/* Using the init_table to enable clks at boot is
+		 * deprecated. Clks that need to be enabled through early
+		 * boot, they should be marked as CLK_IS_CRITICAL
+		 */
+		WARN_ON_ONCE(tbl->state);
 		if (tbl->state)
 			if (clk_prepare_enable(clk)) {
 				pr_err("%s: Failed to enable %s\n", __func__,
-- 
1.9.1

      parent reply	other threads:[~2016-05-25 22:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-25 22:24 [PATCH 00/11] Switch to using CRITICAL clks for Tegra Rhyland Klein
2016-05-25 22:24 ` [PATCH 01/11] clk: tegra: Switch to using critical/handoff clks Rhyland Klein
2016-05-25 22:24 ` [PATCH 02/11] clk: tegra20: Mark required clks as CRITICAL Rhyland Klein
2016-05-25 22:24 ` [PATCH 03/11] clk: tegra20: clean up init_table Rhyland Klein
2016-05-25 22:24 ` [PATCH 04/11] clk: tegra30: Mark certain clks as critical Rhyland Klein
2016-05-25 22:24 ` [PATCH 05/11] clk: tegra30: clean up init_table Rhyland Klein
2016-05-25 22:24 ` [PATCH 06/11] clk: tegra114: " Rhyland Klein
2016-05-25 22:24 ` [PATCH 07/11] clk: tegra124: " Rhyland Klein
2016-05-25 22:24 ` [PATCH 08/11] clk: tegra210: Mark required clks as CRITICAL Rhyland Klein
2016-05-25 22:24 ` [PATCH 09/11] clk: tegra210: clean up init_table Rhyland Klein
2016-05-25 22:24 ` [PATCH 10/11] clk: Show CRITICAL clks in clk_summary output Rhyland Klein
2016-05-25 22:24 ` Rhyland Klein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464215071-28696-12-git-send-email-rklein@nvidia.com \
    --to=rklein@nvidia.com \
    --cc=gnurou@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=sboyd@codeaurora.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®