From: David Kershner <david.kershner@unisys.com>
To: <corbet@lwn.net>, <tglx@linutronix.de>, <mingo@redhat.com>,
<hpa@zytor.com>, <david.kershner@unisys.com>,
<gregkh@linuxfoundation.org>, <erik.arfvidson@unisys.com>,
<timothy.sell@unisys.com>, <hofrat@osadl.org>,
<dzickus@redhat.com>, <jes.sorensen@redhat.com>,
<alexander.curtin@unisys.com>, <janani.rvchndrn@gmail.com>,
<sudipm.mukherjee@gmail.com>, <prarit@redhat.com>,
<david.binder@unisys.com>, <nhorman@redhat.com>,
<dan.j.williams@intel.com>, <linux-kernel@vger.kernel.org>,
<linux-doc@vger.kernel.org>,
<driverdev-devel@linuxdriverproject.org>,
<sparmaintainer@unisys.com>
Subject: [PATCH v3 01/30] staging: unisys: visorbus change -1 return values
Date: Sat, 4 Jun 2016 13:27:01 -0400 [thread overview]
Message-ID: <1465061250-18551-2-git-send-email-david.kershner@unisys.com> (raw)
In-Reply-To: <1465061250-18551-1-git-send-email-david.kershner@unisys.com>
From: Erik Arfvidson <erik.arfvidson@unisys.com>
This patch removes the vague -1 return values from the
write_vbus channel functions. Nobody was checking the
return values and the value stored into the vbus info
is not critical to the functioning of the device.
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 33 ++++++++++++++-----------
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 3a147db..2ed9628 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -866,9 +866,12 @@ get_vbus_header_info(struct visorchannel *chan,
/* Write the contents of <info> to the struct
* spar_vbus_channel_protocol.chp_info.
+ *
+ * Returns void since this is debug information and not needed for
+ * device functionality.
*/
-static int
+static void
write_vbus_chp_info(struct visorchannel *chan,
struct spar_vbus_headerinfo *hdr_info,
struct ultra_vbus_deviceinfo *info)
@@ -876,18 +879,19 @@ write_vbus_chp_info(struct visorchannel *chan,
int off = sizeof(struct channel_header) + hdr_info->chp_info_offset;
if (hdr_info->chp_info_offset == 0)
- return -1;
+ return;
- if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
- return -1;
- return 0;
+ visorchannel_write(chan, off, info, sizeof(*info));
}
/* Write the contents of <info> to the struct
* spar_vbus_channel_protocol.bus_info.
+ *
+ * Returns void since this is debug information and not needed for
+ * device functionality.
*/
-static int
+static void
write_vbus_bus_info(struct visorchannel *chan,
struct spar_vbus_headerinfo *hdr_info,
struct ultra_vbus_deviceinfo *info)
@@ -895,17 +899,18 @@ write_vbus_bus_info(struct visorchannel *chan,
int off = sizeof(struct channel_header) + hdr_info->bus_info_offset;
if (hdr_info->bus_info_offset == 0)
- return -1;
+ return;
- if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
- return -1;
- return 0;
+ visorchannel_write(chan, off, info, sizeof(*info));
}
/* Write the contents of <info> to the
* struct spar_vbus_channel_protocol.dev_info[<devix>].
+ *
+ * Returns void since this is debug information and not needed for
+ * device functionality.
*/
-static int
+static void
write_vbus_dev_info(struct visorchannel *chan,
struct spar_vbus_headerinfo *hdr_info,
struct ultra_vbus_deviceinfo *info, int devix)
@@ -915,11 +920,9 @@ write_vbus_dev_info(struct visorchannel *chan,
(hdr_info->device_info_struct_bytes * devix);
if (hdr_info->dev_info_offset == 0)
- return -1;
+ return;
- if (visorchannel_write(chan, off, info, sizeof(*info)) < 0)
- return -1;
- return 0;
+ visorchannel_write(chan, off, info, sizeof(*info));
}
/* For a child device just created on a client bus, fill in
--
1.9.1
next prev parent reply other threads:[~2016-06-04 17:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 17:27 [PATCH v3 00/30] Fixed issues raised by tglx, then move visorbus to drivers/virt David Kershner
2016-06-04 17:27 ` David Kershner [this message]
2016-06-04 17:27 ` [PATCH v3 02/30] staging: unisys: visorchipset change -1 return value David Kershner
2016-06-04 17:27 ` [PATCH v3 03/30] staging: unisys: iovmcall_gnuc.h change -1 return values David Kershner
2016-06-04 17:27 ` [PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters David Kershner
2016-06-07 13:22 ` Neil Horman
2016-06-08 2:13 ` Binder, David Anthony
2016-06-08 13:08 ` Neil Horman
2016-06-08 14:42 ` Binder, David Anthony
2016-06-08 15:00 ` Neil Horman
2016-06-04 17:27 ` [PATCH v3 05/30] staging: unisys: visorbus: remove unused struct David Kershner
2016-06-04 17:27 ` [PATCH v3 06/30] staging: unisys: visorbus: modify format string to match argument David Kershner
2016-06-04 17:27 ` [PATCH v3 07/30] staging: unisys: visornic: Correct comment spelling mistake David Kershner
2016-06-04 17:27 ` [PATCH v3 08/30] staging: unisys: include: Remove thread-related enum members David Kershner
2016-06-04 17:27 ` [PATCH v3 09/30] staging: unisys: visorbus: removed unused periodic_test_workqueue David Kershner
2016-06-04 17:27 ` [PATCH v3 10/30] staging: unisys: visorinput: remove unnecessary locking David Kershner
2016-06-04 17:27 ` [PATCH v3 11/30] staging: unisys: visorbus: use kernel timer instead of workqueue David Kershner
2016-06-07 13:40 ` Neil Horman
2016-06-07 13:47 ` Sell, Timothy C
2016-06-07 13:51 ` Neil Horman
2016-06-04 17:27 ` [PATCH v3 12/30] staging: unisys: visorbus: remove periodic_work.h/.c David Kershner
2016-06-04 17:27 ` [PATCH v3 13/30] staging: unisys: visorbus: Make visordriver_callback_lock a mutex David Kershner
2016-06-04 17:27 ` [PATCH v3 14/30] staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements David Kershner
2016-06-04 17:27 ` [PATCH v3 15/30] staging: unisys: visorbus: Remove unused functions David Kershner
2016-06-04 17:27 ` [PATCH v3 16/30] staging: unisys: Remove reference to unused STANDALONE_CLIENT David Kershner
2016-06-04 17:27 ` [PATCH v3 17/30] staging: unisys: visorbus: remove unused parameter from function David Kershner
2016-06-04 17:27 ` [PATCH v3 18/30] staging: unisys: visorbus: fix commenting in vbusdevinfo.h David Kershner
2016-06-04 17:27 ` [PATCH v3 19/30] staging: unisys: visorbus: fix commenting in visorbus_main.c David Kershner
2016-06-04 17:27 ` [PATCH v3 20/30] staging: unisys: visorbus: fix visorchannel.c comments David Kershner
2016-06-04 17:27 ` [PATCH v3 21/30] staging: unisys: visorbus: Rectify commenting in visorchipset.c David Kershner
2016-06-04 17:27 ` [PATCH v3 22/30] staging: unisys: visorbus: Move visorbus-unique functions to private header David Kershner
2016-06-04 17:27 ` [PATCH v3 23/30] staging: unisys: visorbus: rectify kerneldoc comment for struct David Kershner
2016-06-04 17:27 ` [PATCH v3 24/30] staging: unisys: visorbus: Remove notifier-related code from visorbus David Kershner
2016-06-04 17:27 ` [PATCH v3 25/30] staging: unisys: visorbus: Rename function to follow existing convention David Kershner
2016-06-04 17:27 ` [PATCH v3 26/30] staging: unisys: visorbus: fix visorbus_private.h comments David Kershner
2016-06-04 17:27 ` [PATCH v3 27/30] staging: unisys: Move vbushelper.h to visorbus directory David Kershner
2016-06-04 17:27 ` [PATCH v3 28/30] include: linux: visorbus: Add visorbus to include/linux directory David Kershner
2016-06-04 17:27 ` [PATCH v3 29/30] Documentation: Move visorbus documentation from staging to Documentation/ David Kershner
2016-06-04 17:27 ` [PATCH v3 30/30] drivers: Add visorbus to the drivers directory David Kershner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465061250-18551-2-git-send-email-david.kershner@unisys.com \
--to=david.kershner@unisys.com \
--cc=alexander.curtin@unisys.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=david.binder@unisys.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=dzickus@redhat.com \
--cc=erik.arfvidson@unisys.com \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=hpa@zytor.com \
--cc=janani.rvchndrn@gmail.com \
--cc=jes.sorensen@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nhorman@redhat.com \
--cc=prarit@redhat.com \
--cc=sparmaintainer@unisys.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=tglx@linutronix.de \
--cc=timothy.sell@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®