From: David Kershner <david.kershner@unisys.com>
To: <corbet@lwn.net>, <tglx@linutronix.de>, <mingo@redhat.com>,
<hpa@zytor.com>, <david.kershner@unisys.com>,
<gregkh@linuxfoundation.org>, <erik.arfvidson@unisys.com>,
<timothy.sell@unisys.com>, <hofrat@osadl.org>,
<dzickus@redhat.com>, <jes.sorensen@redhat.com>,
<alexander.curtin@unisys.com>, <janani.rvchndrn@gmail.com>,
<sudipm.mukherjee@gmail.com>, <prarit@redhat.com>,
<david.binder@unisys.com>, <nhorman@redhat.com>,
<dan.j.williams@intel.com>, <linux-kernel@vger.kernel.org>,
<linux-doc@vger.kernel.org>,
<driverdev-devel@linuxdriverproject.org>,
<sparmaintainer@unisys.com>
Subject: [PATCH v3 02/30] staging: unisys: visorchipset change -1 return value
Date: Sat, 4 Jun 2016 13:27:02 -0400 [thread overview]
Message-ID: <1465061250-18551-3-git-send-email-david.kershner@unisys.com> (raw)
In-Reply-To: <1465061250-18551-1-git-send-email-david.kershner@unisys.com>
From: Erik Arfvidson <erik.arfvidson@unisys.com>
This patch changes the vague -1 return value to -EINVAL
It also modifies the caller of parahotplug_request_complete
to check the return value and return appropriate result.
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
---
drivers/staging/unisys/visorbus/visorchipset.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 5ba5936..7f44913 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -1613,7 +1613,7 @@ parahotplug_request_complete(int id, u16 active)
}
spin_unlock(¶hotplug_request_list_lock);
- return -1;
+ return -EINVAL;
}
/*
@@ -2036,11 +2036,14 @@ static ssize_t devicedisabled_store(struct device *dev,
const char *buf, size_t count)
{
unsigned int id;
+ int err;
if (kstrtouint(buf, 10, &id))
return -EINVAL;
- parahotplug_request_complete(id, 0);
+ err = parahotplug_request_complete(id, 0);
+ if (err < 0)
+ return err;
return count;
}
--
1.9.1
next prev parent reply other threads:[~2016-06-04 17:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 17:27 [PATCH v3 00/30] Fixed issues raised by tglx, then move visorbus to drivers/virt David Kershner
2016-06-04 17:27 ` [PATCH v3 01/30] staging: unisys: visorbus change -1 return values David Kershner
2016-06-04 17:27 ` David Kershner [this message]
2016-06-04 17:27 ` [PATCH v3 03/30] staging: unisys: iovmcall_gnuc.h " David Kershner
2016-06-04 17:27 ` [PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters David Kershner
2016-06-07 13:22 ` Neil Horman
2016-06-08 2:13 ` Binder, David Anthony
2016-06-08 13:08 ` Neil Horman
2016-06-08 14:42 ` Binder, David Anthony
2016-06-08 15:00 ` Neil Horman
2016-06-04 17:27 ` [PATCH v3 05/30] staging: unisys: visorbus: remove unused struct David Kershner
2016-06-04 17:27 ` [PATCH v3 06/30] staging: unisys: visorbus: modify format string to match argument David Kershner
2016-06-04 17:27 ` [PATCH v3 07/30] staging: unisys: visornic: Correct comment spelling mistake David Kershner
2016-06-04 17:27 ` [PATCH v3 08/30] staging: unisys: include: Remove thread-related enum members David Kershner
2016-06-04 17:27 ` [PATCH v3 09/30] staging: unisys: visorbus: removed unused periodic_test_workqueue David Kershner
2016-06-04 17:27 ` [PATCH v3 10/30] staging: unisys: visorinput: remove unnecessary locking David Kershner
2016-06-04 17:27 ` [PATCH v3 11/30] staging: unisys: visorbus: use kernel timer instead of workqueue David Kershner
2016-06-07 13:40 ` Neil Horman
2016-06-07 13:47 ` Sell, Timothy C
2016-06-07 13:51 ` Neil Horman
2016-06-04 17:27 ` [PATCH v3 12/30] staging: unisys: visorbus: remove periodic_work.h/.c David Kershner
2016-06-04 17:27 ` [PATCH v3 13/30] staging: unisys: visorbus: Make visordriver_callback_lock a mutex David Kershner
2016-06-04 17:27 ` [PATCH v3 14/30] staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements David Kershner
2016-06-04 17:27 ` [PATCH v3 15/30] staging: unisys: visorbus: Remove unused functions David Kershner
2016-06-04 17:27 ` [PATCH v3 16/30] staging: unisys: Remove reference to unused STANDALONE_CLIENT David Kershner
2016-06-04 17:27 ` [PATCH v3 17/30] staging: unisys: visorbus: remove unused parameter from function David Kershner
2016-06-04 17:27 ` [PATCH v3 18/30] staging: unisys: visorbus: fix commenting in vbusdevinfo.h David Kershner
2016-06-04 17:27 ` [PATCH v3 19/30] staging: unisys: visorbus: fix commenting in visorbus_main.c David Kershner
2016-06-04 17:27 ` [PATCH v3 20/30] staging: unisys: visorbus: fix visorchannel.c comments David Kershner
2016-06-04 17:27 ` [PATCH v3 21/30] staging: unisys: visorbus: Rectify commenting in visorchipset.c David Kershner
2016-06-04 17:27 ` [PATCH v3 22/30] staging: unisys: visorbus: Move visorbus-unique functions to private header David Kershner
2016-06-04 17:27 ` [PATCH v3 23/30] staging: unisys: visorbus: rectify kerneldoc comment for struct David Kershner
2016-06-04 17:27 ` [PATCH v3 24/30] staging: unisys: visorbus: Remove notifier-related code from visorbus David Kershner
2016-06-04 17:27 ` [PATCH v3 25/30] staging: unisys: visorbus: Rename function to follow existing convention David Kershner
2016-06-04 17:27 ` [PATCH v3 26/30] staging: unisys: visorbus: fix visorbus_private.h comments David Kershner
2016-06-04 17:27 ` [PATCH v3 27/30] staging: unisys: Move vbushelper.h to visorbus directory David Kershner
2016-06-04 17:27 ` [PATCH v3 28/30] include: linux: visorbus: Add visorbus to include/linux directory David Kershner
2016-06-04 17:27 ` [PATCH v3 29/30] Documentation: Move visorbus documentation from staging to Documentation/ David Kershner
2016-06-04 17:27 ` [PATCH v3 30/30] drivers: Add visorbus to the drivers directory David Kershner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465061250-18551-3-git-send-email-david.kershner@unisys.com \
--to=david.kershner@unisys.com \
--cc=alexander.curtin@unisys.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=david.binder@unisys.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=dzickus@redhat.com \
--cc=erik.arfvidson@unisys.com \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=hpa@zytor.com \
--cc=janani.rvchndrn@gmail.com \
--cc=jes.sorensen@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nhorman@redhat.com \
--cc=prarit@redhat.com \
--cc=sparmaintainer@unisys.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=tglx@linutronix.de \
--cc=timothy.sell@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®