* [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"
@ 2016-06-04 19:01 Colin King
2016-06-04 19:43 ` Augusto Mecking Caringi
2016-06-06 2:13 ` Fugang Duan
0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2016-06-04 19:01 UTC (permalink / raw)
To: Fugang Duan, netdev; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
trivial fix to spelling mistake in pr_err message
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/freescale/fec_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 3c0255e..96bd210 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec)
cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
if (cycle > 0xFFFF) {
- pr_err("Rx coalesed usec exceeed hardware limiation");
+ pr_err("Rx coalesced usec exceeed hardware limiation");
return -EINVAL;
}
cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
if (cycle > 0xFFFF) {
- pr_err("Rx coalesed usec exceeed hardware limiation");
+ pr_err("Rx coalesced usec exceeed hardware limiation");
return -EINVAL;
}
--
2.8.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"
2016-06-04 19:01 [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced" Colin King
@ 2016-06-04 19:43 ` Augusto Mecking Caringi
2016-06-05 6:36 ` Joe Perches
2016-06-06 2:13 ` Fugang Duan
1 sibling, 1 reply; 4+ messages in thread
From: Augusto Mecking Caringi @ 2016-06-04 19:43 UTC (permalink / raw)
To: Colin King; +Cc: Fugang Duan, netdev, linux-kernel
On Sat, Jun 4, 2016 at 4:01 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fix to spelling mistake in pr_err message
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 3c0255e..96bd210 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec)
>
> cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
> if (cycle > 0xFFFF) {
> - pr_err("Rx coalesed usec exceeed hardware limiation");
> + pr_err("Rx coalesced usec exceeed hardware limiation");
> return -EINVAL;
> }
>
> cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
> if (cycle > 0xFFFF) {
> - pr_err("Rx coalesed usec exceeed hardware limiation");
> + pr_err("Rx coalesced usec exceeed hardware limiation");
> return -EINVAL;
> }
>
s/limiation/limitation
--
Augusto Mecking Caringi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"
2016-06-04 19:43 ` Augusto Mecking Caringi
@ 2016-06-05 6:36 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2016-06-05 6:36 UTC (permalink / raw)
To: Augusto Mecking Caringi, Colin King; +Cc: Fugang Duan, netdev, linux-kernel
On Sat, 2016-06-04 at 16:43 -0300, Augusto Mecking Caringi wrote:
> On Sat, Jun 4, 2016 at 4:01 PM, Colin King <colin.king@canonical.com> wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > trivial fix to spelling mistake in pr_err message
[]
> > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
[]
> > @@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec)
> >
> > cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
> > if (cycle > 0xFFFF) {
> > - pr_err("Rx coalesed usec exceeed hardware limiation");
> > + pr_err("Rx coalesced usec exceeed hardware limiation");
> > return -EINVAL;
> > }
> >
> > cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
> > if (cycle > 0xFFFF) {
> > - pr_err("Rx coalesed usec exceeed hardware limiation");
> > + pr_err("Rx coalesced usec exceeed hardware limiation");
> > return -EINVAL;
> > }
> >
> s/limiation/limitation
Could also add \n terminations to the pr_err uses.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"
2016-06-04 19:01 [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced" Colin King
2016-06-04 19:43 ` Augusto Mecking Caringi
@ 2016-06-06 2:13 ` Fugang Duan
1 sibling, 0 replies; 4+ messages in thread
From: Fugang Duan @ 2016-06-06 2:13 UTC (permalink / raw)
To: Colin King, netdev; +Cc: linux-kernel
From: Colin King <colin.king@canonical.com> Sent: Sunday, June 05, 2016 3:01 AM
> To: Fugang Duan <fugang.duan@nxp.com>; netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Subject: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"
>
> From: Colin Ian King <colin.king@canonical.com>
>
> trivial fix to spelling mistake in pr_err message
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 3c0255e..96bd210 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev,
> struct ethtool_coalesce *ec)
>
> cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
> if (cycle > 0xFFFF) {
> - pr_err("Rx coalesed usec exceeed hardware limiation");
> + pr_err("Rx coalesced usec exceeed hardware limiation");
coalesed -> coalesced, Exceeed -> exceed, limitation-> limitation
So:
pr_err("Rx coalesced usec exceed hardware limitation \n");
> return -EINVAL;
> }
>
> cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
> if (cycle > 0xFFFF) {
> - pr_err("Rx coalesed usec exceeed hardware limiation");
> + pr_err("Rx coalesced usec exceeed hardware limiation");
pr_err("Rx coalesced usec exceed hardware limitation \n");
Of course, pls add "\n" terminate char for all pr_err() in . fec_enet_set_coalesce() function.
Thanks.
> return -EINVAL;
> }
>
> --
> 2.8.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-06 4:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-04 19:01 [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced" Colin King
2016-06-04 19:43 ` Augusto Mecking Caringi
2016-06-05 6:36 ` Joe Perches
2016-06-06 2:13 ` Fugang Duan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®