From: Chris Cesare <chris.cesare@gmail.com>
To: abbotti@mev.co.uk
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Chris Cesare <chris.cesare@gmail.com>
Subject: [PATCH] staging: comedi: serial2002: bare unsigned and unneeded cast styling issues
Date: Wed, 8 Jun 2016 15:59:31 -0400 [thread overview]
Message-ID: <1465415971-30203-1-git-send-email-chris.cesare@gmail.com> (raw)
checkpatch.pl reported two warnings: A bare "unsigned" and an
unnecessary cast. Fixed both.
Signed-off-by: Chris Cesare <chris.cesare@gmail.com>
---
drivers/staging/comedi/drivers/serial2002.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/serial2002.c b/drivers/staging/comedi/drivers/serial2002.c
index 7a1defc..d3c2743 100644
--- a/drivers/staging/comedi/drivers/serial2002.c
+++ b/drivers/staging/comedi/drivers/serial2002.c
@@ -95,7 +95,7 @@ struct serial_data {
#define S2002_CFG_SIGN(x) (((x) >> 13) & 0x1)
#define S2002_CFG_BASE(x) (((x) >> 14) & 0xfffff)
-static long serial2002_tty_ioctl(struct file *f, unsigned op,
+static long serial2002_tty_ioctl(struct file *f, unsigned int op,
unsigned long param)
{
if (f->f_op->unlocked_ioctl)
@@ -379,7 +379,8 @@ static int serial2002_setup_subdevice(struct comedi_subdevice *s,
range_table_list[chan] =
(const struct comedi_lrange *)&range[j];
}
- maxdata_list[chan] = ((long long)1 << cfg[j].bits) - 1;
+ maxdata_list[chan] = (1 << cfg[j].bits) - 1;
+
chan++;
}
}
--
2.7.4
next reply other threads:[~2016-06-08 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 19:59 Chris Cesare [this message]
2016-06-09 9:27 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465415971-30203-1-git-send-email-chris.cesare@gmail.com \
--to=chris.cesare@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®