From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>
Subject: [PATCH] init, fix initcall blacklist for modules
Date: Mon, 13 Jun 2016 08:27:10 -0400 [thread overview]
Message-ID: <1465820830-13421-1-git-send-email-prarit@redhat.com> (raw)
sprint_symbol_no_offset() returns the string "function_name [module_name]"
where [module_name] is not printed for built in kernel functions. This
means that the initcall blacklisting code will now always fail when
comparing module_init() function names. This patch resolves the issue by
comparing to the length of the function_name.
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
---
init/main.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/init/main.c b/init/main.c
index 4c17fda5c2ff..09a795e91efe 100644
--- a/init/main.c
+++ b/init/main.c
@@ -708,14 +708,26 @@ static bool __init_or_module initcall_blacklisted(initcall_t fn)
{
struct blacklist_entry *entry;
char fn_name[KSYM_SYMBOL_LEN];
+ char *space;
+ int length;
if (list_empty(&blacklisted_initcalls))
return false;
sprint_symbol_no_offset(fn_name, (unsigned long)fn);
+ /*
+ * fn will be "function_name [module_name]" where [module_name] is not
+ * displayed for built-in initcall functions. Strip off the
+ * [module_name].
+ */
+ space = strchrnul(fn_name, ' ');
+ if (!space)
+ length = strlen(fn_name);
+ else
+ length = space - fn_name;
list_for_each_entry(entry, &blacklisted_initcalls, next) {
- if (!strcmp(fn_name, entry->buf)) {
+ if (!strncmp(fn_name, entry->buf, length)) {
pr_debug("initcall %s blacklisted\n", fn_name);
return true;
}
--
1.7.9.3
next reply other threads:[~2016-06-13 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 12:27 Prarit Bhargava [this message]
2016-06-13 12:29 Prarit Bhargava
2016-06-13 20:59 ` Rasmus Villemoes
2016-06-14 9:59 ` Prarit Bhargava
2016-06-14 22:31 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465820830-13421-1-git-send-email-prarit@redhat.com \
--to=prarit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome