From: Andrew Morton <akpm@linux-foundation.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Yang Shi <yang.shi@linaro.org>, Ingo Molnar <mingo@kernel.org>,
Mel Gorman <mgorman@suse.de>, Kees Cook <keescook@chromium.org>,
Yaowei Bai <baiyaowei@cmss.chinamobile.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>
Subject: Re: [PATCH] init, fix initcall blacklist for modules
Date: Tue, 14 Jun 2016 15:31:43 -0700 [thread overview]
Message-ID: <20160614153143.5fcc2d3ff6dcfc4a04e6171b@linux-foundation.org> (raw)
In-Reply-To: <575FD592.2020303@redhat.com>
On Tue, 14 Jun 2016 05:59:46 -0400 Prarit Bhargava <prarit@redhat.com> wrote:
> On 06/13/2016 04:59 PM, Rasmus Villemoes wrote:
> > On Mon, Jun 13 2016, Prarit Bhargava <prarit@redhat.com> wrote:
> >
> >> Sorry ... forgot to cc everyone on the last email.
> >>
> >> P.
> >>
> >> ----8<----
> >>
> >> sprint_symbol_no_offset() returns the string "function_name [module_name]"
> >> where [module_name] is not printed for built in kernel functions. This
> >> means that the initcall blacklisting code will now always fail when
> >
> > I was and am pretty sure that %pf ends up using
> > sprint_symbol_no_offset(), so I don't see how this is new. But maybe
> > "now" doesn't refer to c8cdd2be21?
>
> Oops. I can see how you read that that way. No, this isn't caused by or
> "Fixes:" c8cdd2be21. At some point "%pF" changed its behavior and blacklisting
> module_init() functions stopped working.
Well can we please have a v2 with a complete changelog which identifies
when the regression occurred? That will help in deciding which kernel
versions need fixing.
next prev parent reply other threads:[~2016-06-14 22:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 12:29 Prarit Bhargava
2016-06-13 20:59 ` Rasmus Villemoes
2016-06-14 9:59 ` Prarit Bhargava
2016-06-14 22:31 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-06-13 12:27 Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614153143.5fcc2d3ff6dcfc4a04e6171b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
--cc=yang.shi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome