* [PATCH] PM: Make pm_prepare_console() return void
@ 2016-06-14 14:23 Borislav Petkov
2016-06-16 13:59 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Borislav Petkov @ 2016-06-14 14:23 UTC (permalink / raw)
To: linux-pm; +Cc: LKML
From: Borislav Petkov <bp@suse.de>
Nothing is using its return value so change it to return void.
No functionality change.
Signed-off-by: Borislav Petkov <bp@suse.de>
---
include/linux/suspend.h | 5 ++---
kernel/power/console.c | 8 ++++----
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/include/linux/suspend.h b/include/linux/suspend.h
index 8b6ec7ef0854..7693e39b14fe 100644
--- a/include/linux/suspend.h
+++ b/include/linux/suspend.h
@@ -18,12 +18,11 @@ static inline void pm_set_vt_switch(int do_switch)
#endif
#ifdef CONFIG_VT_CONSOLE_SLEEP
-extern int pm_prepare_console(void);
+extern void pm_prepare_console(void);
extern void pm_restore_console(void);
#else
-static inline int pm_prepare_console(void)
+static inline void pm_prepare_console(void)
{
- return 0;
}
static inline void pm_restore_console(void)
diff --git a/kernel/power/console.c b/kernel/power/console.c
index aba9c545a0e3..0e781798b0b3 100644
--- a/kernel/power/console.c
+++ b/kernel/power/console.c
@@ -126,17 +126,17 @@ out:
return ret;
}
-int pm_prepare_console(void)
+void pm_prepare_console(void)
{
if (!pm_vt_switch())
- return 0;
+ return;
orig_fgconsole = vt_move_to_console(SUSPEND_CONSOLE, 1);
if (orig_fgconsole < 0)
- return 1;
+ return;
orig_kmsg = vt_kmsg_redirect(SUSPEND_CONSOLE);
- return 0;
+ return;
}
void pm_restore_console(void)
--
2.7.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PM: Make pm_prepare_console() return void
2016-06-14 14:23 [PATCH] PM: Make pm_prepare_console() return void Borislav Petkov
@ 2016-06-16 13:59 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2016-06-16 13:59 UTC (permalink / raw)
To: Borislav Petkov; +Cc: linux-pm, LKML
On Tuesday, June 14, 2016 04:23:22 PM Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Nothing is using its return value so change it to return void.
>
> No functionality change.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-16 13:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-14 14:23 [PATCH] PM: Make pm_prepare_console() return void Borislav Petkov
2016-06-16 13:59 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome