From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: rtc-linux@googlegroups.com
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-kernel@vger.kernel.org,
Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 02/13] RTC: ds1307: Disable square wave and timers as default
Date: Tue, 14 Jun 2016 22:59:28 -0700 [thread overview]
Message-ID: <1465970379-14703-3-git-send-email-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <1465970379-14703-1-git-send-email-andrew.smirnov@gmail.com>
Disable square wave and timers as default for DS1337/39/41 and
DS3231. The rationale being that configuring a chip this way puts it
into a known state with lower power consumption. While it is not very
likely it is still possible that the code controlling RTCs that ran
before this driver configured it to produce square wave and left it in
such a state.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
drivers/rtc/rtc-ds1307.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 7e65e2e..c618c22 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -1320,19 +1320,17 @@ static int ds1307_probe(struct i2c_client *client,
ds1307->regs[0] &= ~DS1337_BIT_nEOSC;
/*
- * Using IRQ or defined as wakeup-source?
* Disable the square wave and both alarms.
* For some variants, be sure alarms can trigger when we're
* running on Vbackup (BBSQI/BBSQW)
*/
- if (chip->alarm && (ds1307->client->irq > 0 ||
- ds1307_can_wakeup_device)) {
- ds1307->regs[0] |= DS1337_BIT_INTCN
- | bbsqi_bitpos[ds1307->type];
- ds1307->regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE);
+ ds1307->regs[0] |= DS1337_BIT_INTCN
+ | bbsqi_bitpos[ds1307->type];
+ ds1307->regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE);
+ if (chip->alarm && (ds1307->client->irq > 0 ||
+ ds1307_can_wakeup_device))
want_irq = true;
- }
i2c_smbus_write_byte_data(client, DS1337_REG_CONTROL,
ds1307->regs[0]);
--
2.5.5
next prev parent reply other threads:[~2016-06-15 6:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 5:59 [PATCH 00/13] DS1341 support and code cleanup Andrey Smirnov
2016-06-15 5:59 ` [PATCH 01/13] RTC: ds1307: Add DS1341 variant Andrey Smirnov
2016-06-15 5:59 ` Andrey Smirnov [this message]
2016-06-15 5:59 ` [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Andrey Smirnov
2016-06-19 14:29 ` Rob Herring
2016-06-19 18:12 ` Andrey Smirnov
2016-06-21 20:49 ` Rob Herring
2016-06-21 21:07 ` Alexandre Belloni
2016-06-22 2:34 ` Andrey Smirnov
2016-07-12 16:21 ` Andrey Smirnov
2016-07-19 22:47 ` Alexandre Belloni
2016-07-19 23:56 ` Andrey Smirnov
2016-07-20 9:02 ` Alexandre Belloni
2016-07-20 14:36 ` Andrey Smirnov
2016-07-20 15:38 ` Alexandre Belloni
2016-07-20 16:11 ` Andrey Smirnov
2016-06-21 23:23 ` Andrey Smirnov
2016-06-15 5:59 ` [PATCH 04/13] RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate Andrey Smirnov
2016-06-15 5:59 ` [PATCH 05/13] RTC: ds1307: Convert want_irq " Andrey Smirnov
2016-06-15 5:59 ` [PATCH 06/13] RTC: ds1307: Move chip configuration into a separate routine Andrey Smirnov
2016-06-15 5:59 ` [PATCH 07/13] RTC: ds1307: Move chip sanity checking " Andrey Smirnov
2016-06-15 5:59 ` [PATCH 08/13] RTC: ds1307: Remove register "cache" Andrey Smirnov
2016-06-15 5:59 ` [PATCH 09/13] RTC: ds1307: Constify struct ds1307 where possible Andrey Smirnov
2016-06-15 5:59 ` [PATCH 10/13] RTC: ds1307: Convert goto to a loop Andrey Smirnov
2016-06-15 5:59 ` [PATCH 11/13] RTC: ds1307: Redefine RX8025_REG_* to minimize extra code Andrey Smirnov
2016-06-15 5:59 ` [PATCH 12/13] RTC: ds1307: Report oscillator problems more intelligently Andrey Smirnov
2016-06-15 5:59 ` [PATCH 13/13] RTC: ds1307: Move last bits of sanity checking out of chip_configure Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465970379-14703-3-git-send-email-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®