From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: rtc-linux@googlegroups.com
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options
Date: Tue, 14 Jun 2016 22:59:29 -0700 [thread overview]
Message-ID: <1465970379-14703-4-git-send-email-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <1465970379-14703-1-git-send-email-andrew.smirnov@gmail.com>
Add DS1341 specific power-saving options that allow to disable certain
functional aspects of the chip in order to minimize its power
consumption.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
.../devicetree/bindings/rtc/dallas,ds1341.txt | 23 ++++++++++++++++++
drivers/rtc/rtc-ds1307.c | 28 ++++++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1341.txt
diff --git a/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt
new file mode 100644
index 0000000..b8be7a4
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt
@@ -0,0 +1,23 @@
+* Dallas DS1341 I2C Serial Real-Time Clock
+
+Required properties:
+
+- compatible: Should contain "dallas,ds1341".
+
+- reg: I2C address for chip
+
+Optional properties:
+
+- disable-oscillator-stop-flag : Configure chip to disable oscillator
+ fault detection circuitry
+
+- enable-glitch-filter : Configure chip to enable crystal oscillator
+ output glitch filtering
+
+Example:
+ ds1341: rtc@68 {
+ compatible = "dallas,ds1341";
+ disable-oscillator-stop-flag;
+ enable-glitch-filter;
+ reg = <0x68>;
+ };
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index c618c22..54cc527 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -78,6 +78,7 @@ enum ds_type {
#define DS1337_REG_CONTROL 0x0e
# define DS1337_BIT_nEOSC 0x80
# define DS1339_BIT_BBSQI 0x20
+# define DS1341_BIT_EGFIL 0x20
# define DS3231_BIT_BBSQW 0x40 /* same as BBSQI */
# define DS1337_BIT_RS2 0x10
# define DS1337_BIT_RS1 0x08
@@ -93,7 +94,9 @@ enum ds_type {
# define DS1340_BIT_OSF 0x80
#define DS1337_REG_STATUS 0x0f
# define DS1337_BIT_OSF 0x80
+# define DS1341_BIT_DOSF 0x40
# define DS3231_BIT_EN32KHZ 0x08
+# define DS1341_BIT_ECLK 0x04
# define DS1337_BIT_A2I 0x02
# define DS1337_BIT_A1I 0x01
#define DS1339_REG_ALARM1_SECS 0x07
@@ -1319,6 +1322,31 @@ static int ds1307_probe(struct i2c_client *client,
if (ds1307->regs[0] & DS1337_BIT_nEOSC)
ds1307->regs[0] &= ~DS1337_BIT_nEOSC;
+ if (ds1307->type == ds_1341) {
+ /* Make sure we are not generating square wave
+ * output */
+ ds1307->regs[1] &= ~DS1341_BIT_ECLK;
+
+ if (of_property_read_bool(client->dev.of_node,
+ "disable-oscillator-stop-flag"))
+ ds1307->regs[1] |= DS1341_BIT_DOSF;
+ else
+ ds1307->regs[1] &= ~DS1341_BIT_DOSF;
+
+ if (of_property_read_bool(client->dev.of_node,
+ "enable-glitch-filter"))
+ ds1307->regs[0] |= DS1341_BIT_EGFIL;
+ else
+ ds1307->regs[0] &= ~DS1341_BIT_EGFIL;
+
+ /*
+ * Write status register. Control register
+ * would be set by the code below
+ */
+ i2c_smbus_write_byte_data(client, DS1337_REG_STATUS,
+ ds1307->regs[1]);
+ }
+
/*
* Disable the square wave and both alarms.
* For some variants, be sure alarms can trigger when we're
--
2.5.5
next prev parent reply other threads:[~2016-06-15 6:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 5:59 [PATCH 00/13] DS1341 support and code cleanup Andrey Smirnov
2016-06-15 5:59 ` [PATCH 01/13] RTC: ds1307: Add DS1341 variant Andrey Smirnov
2016-06-15 5:59 ` [PATCH 02/13] RTC: ds1307: Disable square wave and timers as default Andrey Smirnov
2016-06-15 5:59 ` Andrey Smirnov [this message]
2016-06-19 14:29 ` [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Rob Herring
2016-06-19 18:12 ` Andrey Smirnov
2016-06-21 20:49 ` Rob Herring
2016-06-21 21:07 ` Alexandre Belloni
2016-06-22 2:34 ` Andrey Smirnov
2016-07-12 16:21 ` Andrey Smirnov
2016-07-19 22:47 ` Alexandre Belloni
2016-07-19 23:56 ` Andrey Smirnov
2016-07-20 9:02 ` Alexandre Belloni
2016-07-20 14:36 ` Andrey Smirnov
2016-07-20 15:38 ` Alexandre Belloni
2016-07-20 16:11 ` Andrey Smirnov
2016-06-21 23:23 ` Andrey Smirnov
2016-06-15 5:59 ` [PATCH 04/13] RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate Andrey Smirnov
2016-06-15 5:59 ` [PATCH 05/13] RTC: ds1307: Convert want_irq " Andrey Smirnov
2016-06-15 5:59 ` [PATCH 06/13] RTC: ds1307: Move chip configuration into a separate routine Andrey Smirnov
2016-06-15 5:59 ` [PATCH 07/13] RTC: ds1307: Move chip sanity checking " Andrey Smirnov
2016-06-15 5:59 ` [PATCH 08/13] RTC: ds1307: Remove register "cache" Andrey Smirnov
2016-06-15 5:59 ` [PATCH 09/13] RTC: ds1307: Constify struct ds1307 where possible Andrey Smirnov
2016-06-15 5:59 ` [PATCH 10/13] RTC: ds1307: Convert goto to a loop Andrey Smirnov
2016-06-15 5:59 ` [PATCH 11/13] RTC: ds1307: Redefine RX8025_REG_* to minimize extra code Andrey Smirnov
2016-06-15 5:59 ` [PATCH 12/13] RTC: ds1307: Report oscillator problems more intelligently Andrey Smirnov
2016-06-15 5:59 ` [PATCH 13/13] RTC: ds1307: Move last bits of sanity checking out of chip_configure Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465970379-14703-4-git-send-email-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®