mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] init, allow blacklisting of module_init functions
@ 2016-06-17  0:46 Prarit Bhargava
  0 siblings, 0 replies; only message in thread
From: Prarit Bhargava @ 2016-06-17  0:46 UTC (permalink / raw)
  To: linux-kernel
  Cc: Prarit Bhargava, Andrew Morton, Thomas Gleixner, Yang Shi,
	Ingo Molnar, Mel Gorman, Rasmus Villemoes, Kees Cook, Yaowei Bai,
	Andrey Ryabinin

sprint_symbol_no_offset() returns the string "function_name [module_name]"
where [module_name] is not printed for built in kernel functions.  This
means that the blacklisting code will fail when comparing module function
names with the extended string.  This patch adds the functionality to
block a module's module_init() function by finding the space in the string
and truncating the comparison to that length.

[v2]: linux@rasmusvillemoes.dk, switch to strreplace()

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Yang Shi <yang.shi@linaro.org>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Kees Cook <keescook@chromium.org>
Cc: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
---
 init/main.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/init/main.c b/init/main.c
index 4c17fda5c2ff..e8fb1b537d08 100644
--- a/init/main.c
+++ b/init/main.c
@@ -713,6 +713,11 @@ static bool __init_or_module initcall_blacklisted(initcall_t fn)
 		return false;
 
 	sprint_symbol_no_offset(fn_name, (unsigned long)fn);
+	/*
+	 * fn will be "function_name [module_name]" where [module_name] is not
+	 * displayed for built-in init functions.  Strip off the [module_name].
+	 */
+	strreplace(fn_name, ' ', '\0');
 
 	list_for_each_entry(entry, &blacklisted_initcalls, next) {
 		if (!strcmp(fn_name, entry->buf)) {
-- 
1.7.9.3

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-06-17  0:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-17  0:46 [PATCH v2] init, allow blacklisting of module_init functions Prarit Bhargava

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®