From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls
Date: Sun, 26 Jun 2016 18:26:19 -0700 [thread overview]
Message-ID: <1466990779.1847.78.camel@perches.com> (raw)
In-Reply-To: <1466990029.1847.74.camel@perches.com>
On Sun, 2016-06-26 at 18:13 -0700, Joe Perches wrote:
> On Sun, 2016-06-26 at 19:18 -0500, Larry Finger wrote:
> >
> > On 06/26/2016 02:34 PM, Joe Perches wrote:
> > >
> > >
> > > RT_TRACE does not add a newline to the end of a message and always
> > > emits at KERN_DEBUG so these are susceptible to message
> > > interleaving
> > > from other processes without the newline.
> > >
> > > Signed-off-by: Joe Perches <joe@perches.com>
> > > ---
> > This patch does not apply to the wireless-drivers-next repo. Which
> > one
> > did you use?
> linux-next
btw: both patches seem to apply to wireless-drivers-next just fine.
$ git rev-parse HEAD
1bb57c8a5e33bcbec031ce0c629968922d5af89d
$ git am ../next/0001-rtlwifi-Create-_rtl_dbg_trace-function-to-reduce-RT_.patch
Applying: rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size
$ git am ../next/0001-rtlwifi-Add-missing-newlines-to-RT_TRACE-calls.patch
Applying: rtlwifi: Add missing newlines to RT_TRACE calls
next prev parent reply other threads:[~2016-06-27 1:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 19:34 Joe Perches
2016-06-27 0:18 ` Larry Finger
2016-06-27 1:13 ` Joe Perches
2016-06-27 1:26 ` Joe Perches [this message]
2016-06-27 1:49 ` Larry Finger
2016-07-08 9:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466990779.1847.78.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome