* [PATCH] mmc: sdhci: Do not allow tuning procedure to be interrupted
@ 2016-07-22 14:17 robert.foss
0 siblings, 0 replies; only message in thread
From: robert.foss @ 2016-07-22 14:17 UTC (permalink / raw)
To: linux-kernel, linux-mmc, aisheng.dong, suneel.garapati,
wenkai.du, johan.derycke, ludovic.desroches, haibo.chen,
ivan.ivanov, ulf.hansson
Cc: enric.balletbo, tomeu.vizoso, Christopher Freeman
From: Christopher Freeman <cfreeman@nvidia.com>
wait_event_interruptible_timeout() will return early if the blocked
process receives a signal, causing the driver to abort the tuning
procedure and possibly leaving the controller in a bad state. Since the
tuning command is expected to complete quickly (<50ms) and we've set a
timeout, use wait_event_timeout() instead.
Signed-off-by: Christopher Freeman <cfreeman@nvidia.com>
---
drivers/mmc/host/sdhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index ef3eee7..2029090 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2009,7 +2009,7 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
spin_unlock_irqrestore(&host->lock, flags);
/* Wait for Buffer Read Ready interrupt */
- wait_event_interruptible_timeout(host->buf_ready_int,
+ wait_event_timeout(host->buf_ready_int,
(host->tuning_done == 1),
msecs_to_jiffies(50));
spin_lock_irqsave(&host->lock, flags);
--
2.7.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-07-22 14:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-22 14:17 [PATCH] mmc: sdhci: Do not allow tuning procedure to be interrupted robert.foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome