From: Oleg Drokin <green@linuxhacker.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>,
Oleg Drokin <green@linuxhacker.ru>
Subject: [PATCH 11/15] staging/lustre: Always return EEXIST on mkdir for existing names
Date: Sat, 23 Jul 2016 02:37:08 -0400 [thread overview]
Message-ID: <1469255832-746785-12-git-send-email-green@linuxhacker.ru> (raw)
In-Reply-To: <1469255832-746785-1-git-send-email-green@linuxhacker.ru>
if the name already exists, but we don't have write permissions
in the parent, force talking to the MDS to determine what
more sensical error code to return.
This also happens to fix matlab and other such programs that
assume that EEXIST is the only valid error code for mkdir of
an existing directory.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/staging/lustre/lustre/llite/namei.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c
index 2c4dc69..d219d06 100644
--- a/drivers/staging/lustre/lustre/llite/namei.c
+++ b/drivers/staging/lustre/lustre/llite/namei.c
@@ -541,8 +541,12 @@ static struct dentry *ll_lookup_nd(struct inode *parent, struct dentry *dentry,
CDEBUG(D_VFSTRACE, "VFS Op:name=%pd, dir="DFID"(%p),flags=%u\n",
dentry, PFID(ll_inode2fid(parent)), parent, flags);
- /* Optimize away (CREATE && !OPEN). Let .create handle the race. */
- if ((flags & LOOKUP_CREATE) && !(flags & LOOKUP_OPEN))
+ /* Optimize away (CREATE && !OPEN). Let .create handle the race.
+ * but only if we have write permissions there, otherwise we need
+ * to proceed with lookup. LU-4185
+ */
+ if ((flags & LOOKUP_CREATE) && !(flags & LOOKUP_OPEN) &&
+ (inode_permission(parent, MAY_WRITE | MAY_EXEC) == 0))
return NULL;
if (flags & (LOOKUP_PARENT|LOOKUP_OPEN|LOOKUP_CREATE))
--
2.7.4
next prev parent reply other threads:[~2016-07-23 6:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-23 6:36 [PATCH 00/15] Lustre cleanups Oleg Drokin
2016-07-23 6:36 ` [PATCH 01/15] lustre: switch lnet_sock_write() to sock_sendmsg() Oleg Drokin
2016-07-23 6:36 ` [PATCH 02/15] lustre: simplify the living hell out of ksocknal_lib_recv_kiov() Oleg Drokin
2016-07-23 6:37 ` [PATCH 03/15] lustre: don't reinvent struct bio_vec Oleg Drokin
2016-07-23 6:37 ` [PATCH 04/15] ksocknal_lib_recv_iov(): recvmsg doesn't bugger iovec anymore Oleg Drokin
2016-07-23 6:37 ` [PATCH 05/15] ksocknal_lib_send_iov(): sendmsg doesn't bugger iovec Oleg Drokin
2016-07-23 6:37 ` [PATCH 06/15] ksocknal_lib_send_kiov(): " Oleg Drokin
2016-07-23 6:37 ` [PATCH 07/15] lustre: ->kss_scratch... are unused now Oleg Drokin
2016-08-15 16:55 ` Greg Kroah-Hartman
2016-07-23 6:37 ` [PATCH 08/15] lustre: constify lib-move.c stuff Oleg Drokin
2016-07-23 6:37 ` [PATCH 09/15] lustre: pass iov_iter to ->lnd_recv() Oleg Drokin
2016-07-23 6:37 ` [PATCH 10/15] lustre: introduce lnet_copy_{k,}iov2iter(), kill lnet_copy_{k,}iov2{k,}iov() Oleg Drokin
2016-07-23 6:37 ` Oleg Drokin [this message]
2016-07-23 6:37 ` [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}' Oleg Drokin
2016-07-23 17:31 ` Joe Perches
2016-07-23 18:01 ` Oleg Drokin
2016-07-26 1:47 ` Joe Perches
2016-07-23 6:37 ` [PATCH 13/15] staging/lustre: Fix unnecessary parentheses around variables Oleg Drokin
2016-07-23 6:37 ` [PATCH 14/15] staging/lustre: Make alignment match open parenthesis Oleg Drokin
2016-07-23 6:37 ` [PATCH 15/15] staging/lustre: Remove unused cp_error from struct cl_page Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469255832-746785-12-git-send-email-green@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome