From: Oleg Drokin <green@linuxhacker.ru>
To: Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>,
Emoly Liu <emoly.liu@intel.com>
Subject: Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}'
Date: Sat, 23 Jul 2016 14:01:14 -0400 [thread overview]
Message-ID: <974D47D2-320C-42C0-BA73-1DA12B73737F@linuxhacker.ru> (raw)
In-Reply-To: <1469295072.1900.162.camel@perches.com>
On Jul 23, 2016, at 1:31 PM, Joe Perches wrote:
> On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote:
>> From: Emoly Liu <emoly.liu@intel.com>
>
> unrelated trivial notes:
>
>> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h b/drivers/staging/lustre/lustre/obdecho/echo_internal.h
> []
>> @@ -33,9 +33,9 @@
>>
>> /* The persistent object (i.e. actually stores stuff!) */
>> #define ECHO_PERSISTENT_OBJID 1ULL
>> -#define ECHO_PERSISTENT_SIZE ((__u64)(1<<20))
>> +#define ECHO_PERSISTENT_SIZE ((__u64)(1 << 20))
>
> This is generally an error-prone pattern as the cast is
> done after the shift.
Hm, indeed.
> Perhaps better is using a specific type
>
> #define ECHO_PERSISTENT_SIZE (1ULL << 20)
Yes, I guess this is a better way.
> And lustre seems to use types with unnecessary __ prefixes.
Need to see if this file is included in userspace where the __ is needed.
next prev parent reply other threads:[~2016-07-23 18:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-23 6:36 [PATCH 00/15] Lustre cleanups Oleg Drokin
2016-07-23 6:36 ` [PATCH 01/15] lustre: switch lnet_sock_write() to sock_sendmsg() Oleg Drokin
2016-07-23 6:36 ` [PATCH 02/15] lustre: simplify the living hell out of ksocknal_lib_recv_kiov() Oleg Drokin
2016-07-23 6:37 ` [PATCH 03/15] lustre: don't reinvent struct bio_vec Oleg Drokin
2016-07-23 6:37 ` [PATCH 04/15] ksocknal_lib_recv_iov(): recvmsg doesn't bugger iovec anymore Oleg Drokin
2016-07-23 6:37 ` [PATCH 05/15] ksocknal_lib_send_iov(): sendmsg doesn't bugger iovec Oleg Drokin
2016-07-23 6:37 ` [PATCH 06/15] ksocknal_lib_send_kiov(): " Oleg Drokin
2016-07-23 6:37 ` [PATCH 07/15] lustre: ->kss_scratch... are unused now Oleg Drokin
2016-08-15 16:55 ` Greg Kroah-Hartman
2016-07-23 6:37 ` [PATCH 08/15] lustre: constify lib-move.c stuff Oleg Drokin
2016-07-23 6:37 ` [PATCH 09/15] lustre: pass iov_iter to ->lnd_recv() Oleg Drokin
2016-07-23 6:37 ` [PATCH 10/15] lustre: introduce lnet_copy_{k,}iov2iter(), kill lnet_copy_{k,}iov2{k,}iov() Oleg Drokin
2016-07-23 6:37 ` [PATCH 11/15] staging/lustre: Always return EEXIST on mkdir for existing names Oleg Drokin
2016-07-23 6:37 ` [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}' Oleg Drokin
2016-07-23 17:31 ` Joe Perches
2016-07-23 18:01 ` Oleg Drokin [this message]
2016-07-26 1:47 ` Joe Perches
2016-07-23 6:37 ` [PATCH 13/15] staging/lustre: Fix unnecessary parentheses around variables Oleg Drokin
2016-07-23 6:37 ` [PATCH 14/15] staging/lustre: Make alignment match open parenthesis Oleg Drokin
2016-07-23 6:37 ` [PATCH 15/15] staging/lustre: Remove unused cp_error from struct cl_page Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=974D47D2-320C-42C0-BA73-1DA12B73737F@linuxhacker.ru \
--to=green@linuxhacker.ru \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=emoly.liu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®