mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Allen Hubbe <allenbh@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] checkpatch: check signoff when reading stdin
Date: Fri, 29 Jul 2016 08:38:41 -0700	[thread overview]
Message-ID: <1469806721.3998.80.camel@perches.com> (raw)
In-Reply-To: <CAJ80savCTr5whQ2LZ9iaSNfT-pkaYTGd9TWCBTNRq6uBv6V1Jg@mail.gmail.com>

On Fri, 2016-07-29 at 10:45 -0400, Allen Hubbe wrote:
> On Wed, Jul 27, 2016 at 8:41 PM, Joe Perches <joe@perches.com> wrote:
> > 
> > I think this is not a great idea because the most likely
> > use case is piping git diff output ala:
> > 
> > $ git diff <some_path> | ./scripts/checkpatch.pl -
> Thanks for the review.  Has v2 addressed your concern?

Hi Allen.

For the most part, yes, your V2 works better.

I was wondering if the - should be optional and thinking
$ git diff <some-path> | ./scripts/checkpatch.pl
should work the same way, but I guess that can wait for
another day, so

Acked-by: Joe Perches <joe@perches.com>

cheers, Joe

  reply	other threads:[~2016-07-29 15:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27 23:05 Allen Hubbe
2016-07-28  0:41 ` Joe Perches
2016-07-29 14:45   ` Allen Hubbe
2016-07-29 15:38     ` Joe Perches [this message]
2016-07-28  1:53 ` [PATCH v2] " Allen Hubbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469806721.3998.80.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=allenbh@gmail.com \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®