* [PATCH] staging: comedi/drivers: Fixed sparse warnings
@ 2016-07-30 16:38 Nayeemahmed Badebade
2016-08-02 16:41 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Nayeemahmed Badebade @ 2016-07-30 16:38 UTC (permalink / raw)
To: abbotti, hsweeten; +Cc: gregkh, devel, linux-kernel
Fixed below sparse warnings in dt2811.c
warning: symbol 'dt2811_clk_dividers' was not declared. Should it be static?
warning: symbol 'dt2811_clk_multipliers' was not declared. Should it be static?
Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@gmail.com>
---
drivers/staging/comedi/drivers/dt2811.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c
index 904f6377..07f99c0 100644
--- a/drivers/staging/comedi/drivers/dt2811.c
+++ b/drivers/staging/comedi/drivers/dt2811.c
@@ -96,11 +96,11 @@
* 6 6 100 kHz 6 1000000
* 7 12 50 kHz 7 10000000
*/
-const unsigned int dt2811_clk_dividers[] = {
+static const unsigned int dt2811_clk_dividers[] = {
1, 10, 2, 3, 4, 5, 6, 12
};
-const unsigned int dt2811_clk_multipliers[] = {
+static const unsigned int dt2811_clk_multipliers[] = {
1, 10, 100, 1000, 10000, 100000, 1000000, 10000000
};
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging: comedi/drivers: Fixed sparse warnings
2016-07-30 16:38 [PATCH] staging: comedi/drivers: Fixed sparse warnings Nayeemahmed Badebade
@ 2016-08-02 16:41 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2016-08-02 16:41 UTC (permalink / raw)
To: Nayeemahmed Badebade, hsweeten; +Cc: gregkh, devel, linux-kernel
On 30/07/16 17:38, Nayeemahmed Badebade wrote:
> Fixed below sparse warnings in dt2811.c
> warning: symbol 'dt2811_clk_dividers' was not declared. Should it be static?
> warning: symbol 'dt2811_clk_multipliers' was not declared. Should it be static?
>
> Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@gmail.com>
> ---
> drivers/staging/comedi/drivers/dt2811.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c
> index 904f6377..07f99c0 100644
> --- a/drivers/staging/comedi/drivers/dt2811.c
> +++ b/drivers/staging/comedi/drivers/dt2811.c
> @@ -96,11 +96,11 @@
> * 6 6 100 kHz 6 1000000
> * 7 12 50 kHz 7 10000000
> */
> -const unsigned int dt2811_clk_dividers[] = {
> +static const unsigned int dt2811_clk_dividers[] = {
> 1, 10, 2, 3, 4, 5, 6, 12
> };
>
> -const unsigned int dt2811_clk_multipliers[] = {
> +static const unsigned int dt2811_clk_multipliers[] = {
> 1, 10, 100, 1000, 10000, 100000, 1000000, 10000000
> };
>
> --
> 1.9.1
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-30 16:38 [PATCH] staging: comedi/drivers: Fixed sparse warnings Nayeemahmed Badebade
2016-08-02 16:41 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®