From: Bibby Hsieh <bibby.hsieh@mediatek.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
James Liao <jamesjj.liao@mediatek.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
YH Huang <yh.huang@mediatek.com>, "CK Hu" <ck.hu@mediatek.com>,
Yong Wu <yong.wu@mediatek.com>,
Eddie Huang <eddie.huang@mediatek.com>,
"dawei.chien@mediatek.com" <dawei.chien@mediatek.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Junzhi Zhao <junzhi.zhao@mediatek.com>
Subject: Re: [PATCH v4] arm64: dts: mt8173: add mmsel clocks for 4K support
Date: Wed, 3 Aug 2016 09:46:56 +0800 [thread overview]
Message-ID: <1470188816.5418.8.camel@mtksdaap41> (raw)
In-Reply-To: <1469785990.3012.35.camel@pengutronix.de>
Hi, Philipp,
On Fri, 2016-07-29 at 11:53 +0200, Philipp Zabel wrote:
> Hi Bibby,
>
> Am Freitag, den 29.07.2016, 17:09 +0800 schrieb Bibby Hsieh:
> > To support HDMI 4K resolution, mmsys need clcok
> > mm_sel to be 400MHz.
> >
> > The board .dts file should override the clock rate
> > property with the higher VENCPLL frequency the board
> > supports HDMI 4K resolution.
> >
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 78529e4..93d4d17 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -690,6 +690,8 @@
> > compatible = "mediatek,mt8173-mmsys", "syscon";
> > reg = <0 0x14000000 0 0x1000>;
> > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > + clocks = <&topckgen CLK_TOP_MM_SEL>;
> > + clock-frequency = <400000000>;
>
> This is unchanged compared to v3, I suggest to use assigned-clocks /
> assigned-clock-rates properties instead.
>
Ok, I will change that, thanks for your review.
--
Bibby
> best regards
> Philipp
>
prev parent reply other threads:[~2016-08-03 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 9:09 Bibby Hsieh
2016-07-29 9:53 ` Philipp Zabel
2016-08-03 1:46 ` Bibby Hsieh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470188816.5418.8.camel@mtksdaap41 \
--to=bibby.hsieh@mediatek.com \
--cc=catalin.marinas@arm.com \
--cc=chunfeng.yun@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=dawei.chien@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=eddie.huang@mediatek.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jamesjj.liao@mediatek.com \
--cc=junzhi.zhao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=will.deacon@arm.com \
--cc=yh.huang@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®